Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up empty liens in vault #167

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Clean up empty liens in vault #167

merged 3 commits into from
Nov 22, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Nov 21, 2023

Closes #101

@uint uint requested a review from maurolacy November 21, 2023 08:10
@uint uint marked this pull request as draft November 21, 2023 08:14
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (191ae6f) 86.72% compared to head (d00adcd) 86.73%.

Files Patch % Lines
contracts/provider/vault/src/contract.rs 82.35% 0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   86.72%   86.73%           
=======================================
  Files          81       81           
  Lines       14036    14041    +5     
  Branches    14036    14041    +5     
=======================================
+ Hits        12173    12178    +5     
  Misses       1300     1300           
  Partials      563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uint uint marked this pull request as ready for review November 21, 2023 19:31
Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

amount: ValueRange::new_val(Uint128::zero()) // TODO? Clean-up empty liens
}]
);
assert_eq!(claims.claims, []);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@uint uint merged commit 737dd0b into main Nov 22, 2023
4 checks passed
@uint uint deleted the 101-empty-liens branch November 22, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native-staking empty liens cleanup
3 participants