Workaround to enable communication between Empty and Custom contracts in mt
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
sylvia-upgrade-custom-empty
branch
from
d0b6a22
to
4938265
Compare
ethanfrey
approved these changes
May 13, 2024
| @@ -22,6 +24,16 @@ pub const CONTRACT_VERSION: &str = env!("CARGO_PKG_VERSION"); | |||
|
|
|||
| const REPLY_ID_INSTANTIATE: u64 = 1; | |||
|
|
|||
| #[cfg(not(any(test, feature = "mt")))] | |||
There was a problem hiding this comment.
Ah very clever... so we make it ask like it uses all these custom messages for test code only
It seems a bit risky (if we actually start using those types, test will pass but production will fail), but for this case, a pretty clean workaround
There was a problem hiding this comment.
I made this a much more explicit fake-custom flag and did some more plumbing (with associated types on the various traits), but this is a great idea to allow the contracts to play well in the test code without all kinds of nastiness when using them.
There was a problem hiding this comment.
Nicely done Ethan ;) Happy to help!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't push to
sylvia-upgradeas there is still an issue while runningvirtual-stakingtests.You can play with this approach. I think this might be the least impact workaround for custom<->empty interoperability in tests.