Implement IBC Validator Sync sub-protocol #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Jun 21, 2023
| } | ||
|
|
||
| #[cfg_attr(not(feature = "library"), entry_point)] | ||
| /// never should be called as we do not send packets | ||
| /// The most we can do here is retry the packet, hoping it will eventually arrive. |
There was a problem hiding this comment.
👍🏼 Perhaps we can introduce number of retries in the future.
maurolacy
reviewed
Jun 22, 2023
maurolacy
reviewed
Jun 22, 2023
packages/apis/src/ibc/packet.rs
Outdated
Comment on lines
78
to
87
|
|
||
| /// This is a generic ICS acknowledgement format. | ||
| /// Proto defined here: https://github.com/cosmos/cosmos-sdk/blob/v0.42.0/proto/ibc/core/channel/v1/channel.proto#L141-L147 | ||
| /// This is compatible with the JSON serialization. | ||
| /// Wasmd uses this same wrapper for unhandled errors. | ||
| #[cw_serde] | ||
| pub enum AckWrapper { | ||
| Result(Binary), | ||
| Error(String), | ||
| } |
There was a problem hiding this comment.
Struct copied from cw20-ics20 (and methods updated).
This is tested to work with wasmd handling
| @@ -132,13 +132,13 @@ pub fn ibc_packet_receive( | |||
| }; | |||
| VAL_CRDT.add_validator(deps.storage, &valoper, update)?; | |||
There was a problem hiding this comment.
Do we capture / map the error(s) here, and return ack_fail instead?
There was a problem hiding this comment.
This is done in wasmd.
If contract panics, it aborts the whole tx (no ack written)
If contract returns error, it wraps the error message in this "standard" struct, which is what I use now as AckWrapper.
| Ok(IbcBasicResponse::new()) | ||
| let ack: AckWrapper = from_slice(&msg.acknowledgement.data)?; | ||
| let mut res = IbcBasicResponse::new(); | ||
| match ack { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the validator sync packets from Consumer (
converter) to Provider (external-staking) and process them into the CRDT type there.Add tests on the CRDT and some queries, so we can (in a future PR) check validators before staking, or associate tendermint double-signs with valoper addresses (next milestone)