Add ibc handling to converter

[ethanfrey]

(Currently untested)

• Add ibc_packet_receive with price normalization and calling the virtual staking contract.
• Add remote denom to the instantiate entry point
• Solve converter / virtual_staking "chicken and egg" problem (see ConverterContract::instantiate)
• Add sudo entry point test ExecMsg variants to allow testing
• Write simple multi-test to test this

[ethanfrey]

Okay, the consumer side is implemented.

Please review, but this has some tests and should be ready to merge.
I tried doing things like:

    #[cfg(test)]
    #[msg(exec)]
    fn demo_stake(

and

    #[cfg_attr(test, msg(exec))]
    fn demo_stake(

but neither worked, as #[msg] doesn't seem to be an attribute but is actually parsed strings by the #[contract] macro.
If you find/know a better way to conditionally compile these methods, only for testing, let me know.

I am happy to use a feature flag as well, but the main part is some sort of cfg directive that plays well with the msg(exec) directive

[maurolacy]

Looks good! Will take a look at the tests next.

[maurolacy]

Nit: Shouldn't this better be called Delegate?

[ethanfrey]

Good question, can you make a different issue on this?
Out of scope of the IBC connection

[maurolacy]

Guess this query will look something like

let price = price_feed.price(config.remote_denom)?.native_per_foreign;

in the (near?) future.

[ethanfrey]

Yes, related issue: CosmWasm/sylvia#181
I will add this to code comment

[maurolacy]

neither worked, as #[msg] doesn't seem to be an attribute but is actually parsed strings by the #[contract] macro. If you find/know a better way to conditionally compile these methods, only for testing, let me know.

I am happy to use a feature flag as well, but the main part is some sort of cfg directive that plays well with the msg(exec) directive

Was trying to do the same to no avail. I think we need to use some form of sudo. The trick with the "ADMIN" check is something I thought but decided not to do. Will work on improving this asap.

[ethanfrey]

BTW, I settled on this:

#[msg(exec)]
    fn test_stake(
        &self,
        ctx: ExecCtx,
        validator: String,
        stake: Coin,
    ) -> Result<Response, ContractError> {
        #[cfg(test)] {
            // This can only ever be called in tests
            self.stake(ctx.deps, validator, stake)
        }
        #[cfg(not(test))] {
            let _ = (ctx, validator, stake);
            Err(ContractError::Unauthorized)
        }
    }

The entry point is still there, but it is compile-time fixed to errors in non-test builds.