Ensure validators are registered before staking #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
commented
Jun 27, 2023
| @@ -115,6 +125,23 @@ fn staking() { | |||
| .call(users[1]) | |||
| .unwrap(); | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Another non-blocking issue in Sylvia.
User calls contract A. contract A returns message to execute contract B. contract B calls fail (no reply registered). A and B both have different ContractError registered.
The caller doesn't ever get the result, but it fails inside ExecProxy when trying to downcast the result to vault::ContractError (contract A). Not sure if the error is external_staking::ContractError (contract B), or StdError, but I want to assert this fails without panic-ing the test
|
Merging this one. Happy for more detailed review later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
This doesn't let a new stake occur unless when know the validator is in the active set.
Added a test command to place a validator in the active set.