Reward payments 1 #76
Conversation
ethanfrey
force-pushed
the
reward-payments-1
branch
from
9c23a06
to
563af2c
Compare
| @@ -56,6 +69,13 @@ pub enum ConsumerPacket { | |||
| /// but when it is no longer a valid target to delegate to. | |||
| /// It contains a list of `valoper_address` to be removed | |||
| RemoveValidators(Vec<String>), | |||
| /// This is part of the rewards protocol | |||
| Distribute { | |||
There was a problem hiding this comment.
And this doesn't need to be transactional, because there's nothing to rollback here.
I wonder, if distribution fails on the provider for whatever reason, would that have an effect on subsequent distribution calls? I mean, couldn't we be distributing more / less than the right amount in some scenario?
There was a problem hiding this comment.
That is a very good question. I made #81 to track this later. Not sure what the proper answer is right now. Not blocking merge but good to keep track of it.
ethanfrey
force-pushed
the
reward-payments-1
branch
from
563af2c
to
0a7f563
Compare
|
@maurolacy I addressed your comments in 0a7f563 if you want to check. And then rebased on main and resolved conflicts with other merges. I think this is more or less ready now. |
Will review tests, just for completeness. |
| @@ -755,16 +752,14 @@ fn distribution() { | |||
| // 20 tokens for users[0] | |||
| // 30 tokens for users[1] | |||
| contract | |||
| .distribute_rewards(validators[0].to_owned()) | |||
| .with_funds(&coins(50, STAR)) | |||
| .test_distribute_rewards(validators[0].to_owned(), coin(50, STAR)) | |||
There was a problem hiding this comment.
This is better / fixed now. Rewards to distribute are virtual here.
This test_ prefix is a little ugly, but makes things clear. Hopefully it will be gone when we're able to test this better.
There was a problem hiding this comment.
Yes, when both Sylvia and cw-multi-test have IBC support this should be much better.
Until then we just fake all ibc packet lifetimes.
I wouldn't assume this to improve til later Q3 (it is on Q3 roadmap though)
ethanfrey
force-pushed
the
reward-payments-1
branch
from
0a7f563
to
0f01711
Compare
Recreate from #69 after a mistaken merge and revert.
Enables rewards to be sent every epoch from consumer to producer and distributed to stakers.
Stakers can withdraw rewards to an account on the consumer chain (where they can be staked), with a message on the provider chain (which knows who staked)