Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe rewards #86

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Maybe rewards #86

merged 5 commits into from
Jun 28, 2023

Conversation

maurolacy
Copy link
Collaborator

Avoids erroring on queries over locked pending rewards.

Copy link
Collaborator

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. One minor nit on promoting enum variants to top-level, otherwise very clean improvement

contracts/provider/external-staking/src/msg.rs Outdated Show resolved Hide resolved
validator: validator.into(),
rewards: Rewards(coin(amount, denom)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change here to make this non-breaking as much as possible

@maurolacy maurolacy merged commit 2b40a96 into main Jun 28, 2023
@maurolacy maurolacy deleted the maybe-rewards branch June 28, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants