-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #91
Update docs #91
Conversation
3183a02
to
c5fab70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read most of this now. Provider + Vault missing.
Lot of good updates. I added some notes where more context would be helpful or some terms were not correct in context of IBC
2. Instantiate external staking contract on the Provider chain (referencing IBC port of the converter). | ||
3. Create IBC channel from Provider to Consumer. | ||
4. Apply to Consumer governance to provide a virtual staking max cap to the associated virtual staking contract, | ||
so that this connection may have voting power. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO max cap limits should be in place before the IBC connection. Technically not mandatory but it would be easy to miss when people see the IBC packets from the Converter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max cap limits are in place before the IBC connection. Max cap is effectively zero until and unless governance increases it.
Update: AFAIK this is a custom query of type VirtualStakeQuery::BondStatus
(See
mesh-security/packages/bindings/src/query.rs
Lines 51 to 54 in 230fe09
pub fn bond_status(&self, contract: String) -> StdResult<BondStatusResponse> { | |
let full_denom_query = VirtualStakeQuery::BondStatus { contract }; | |
self.querier.query(&full_denom_query.into()) | |
} |
This behaviour (returning zero if no gov auth) must be properly enforced by the blockchain answering said query.
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Closes #82
Let's make sure they all reflect the current implementation and design.
Converter+ Price OracleVirtual Staking+ Go ModuleNotes: