feat: added slippage warning for default too high #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
WalkthroughThe changes in the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
p0mvn
approved these changes
Aug 22, 2024
p0mvn
pushed a commit
that referenced
this pull request
Aug 22, 2024
* In Given Out (#3773) * feat: initial in given out implementation * feat: inputs and relative buttons wired in to correct quotes * fix: route display * feat: functioning swaps for in given out * feat: working in given out * fix: improved swap denoms button * chore: remove logs * fix: missing dependencies for hook * fix: readded localstorage for swapped pairs, fixed asset page denoms for limit orders * fix: adjusted gas estimate loading state * fix: asset price chart advance view bg * fix: readded feature flag for limit orders * fix: flipped trade details ratio ordering * fix: limit order ratio shows current market * refactor: replicated disabled/loading state for old swap tool * feat: added out given in to buy/sell * fix: limit input with decimal start * fix: reset now resets output * feat: [WIP] swap exact amount out * fix: price formatting for buy/sell fiat inputs * feat: implemented default slippage for in-given-out * chore: removed log * feat: added new slippage defaults to swap tab * build: fix errors * fix: use swap hook infinite load * feat: added more amplitude events * fix: input starting with . for swap tab * feat: hide percent change when below 1% * feat: market price now shows 0% * chore: updated tooltips * chore: localizations * fix: spacing * fix: removed unused localization * fix: display values for new quote type * chore: localizations * fix: in given out refetch dropped to 10 seconds * fix: sell tab non focused display * feat: dynamic slippage for in-given-out * feat: added inGivenOut feature flag * fix: adjusted slippage resetting * fix: removed unused file * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: renamed slippage variable and fixed comments * fix: added handler for alternate slippage error * feat: added handlers for slippage over balance * fix: loading state for buy/sell tab * refactor: moved amount with slippage calculation to a hook * refactor: cleaned up nonFocusedDisplayAmount * fix: reinstated balance query for exact amount out * fix: added number formatting for swap tab inputs * feat: added OCT to in given out * chore: localizations * refactor: useQueryRouterBestQuote changes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * [In Given Out]: Feature Flag (#3781) * fix: improved inGivenOut FF disabled behavior * fix: clear inputs on swap * fix: added cases for if user has input and in given out ff is disabled * fix: swap inputs on empty value * Swap more OSMO to ATOM (#3782) * (Deposit/Withdraw) Display Keplr EVM correctly (#3771) * [In Given Out]: Default input adjustments (#3784) * fix: button disabled for limit * feat: default display for buy/sell tab * refactor: wrapped updating code in useEffect * fix: loading state for button * feat: added slippage warning for default too high (#3787) * Mattupham/fe 784 portfolio v2 open orders / limit orders (#3786) * open orders * Add base values for limit orders * Add open orders * Clean up styles * Clean up styles * Base i18n * i18n * Update quote asset * fix: remove logs and correct limit input amount (#3788) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: yakuramori <[email protected]> Co-authored-by: Jose Felix <[email protected]> Co-authored-by: Matt Upham <[email protected]>
mattupham
added a commit
that referenced
this pull request
Aug 23, 2024
* In Given Out (#3773) * feat: initial in given out implementation * feat: inputs and relative buttons wired in to correct quotes * fix: route display * feat: functioning swaps for in given out * feat: working in given out * fix: improved swap denoms button * chore: remove logs * fix: missing dependencies for hook * fix: readded localstorage for swapped pairs, fixed asset page denoms for limit orders * fix: adjusted gas estimate loading state * fix: asset price chart advance view bg * fix: readded feature flag for limit orders * fix: flipped trade details ratio ordering * fix: limit order ratio shows current market * refactor: replicated disabled/loading state for old swap tool * feat: added out given in to buy/sell * fix: limit input with decimal start * fix: reset now resets output * feat: [WIP] swap exact amount out * fix: price formatting for buy/sell fiat inputs * feat: implemented default slippage for in-given-out * chore: removed log * feat: added new slippage defaults to swap tab * build: fix errors * fix: use swap hook infinite load * feat: added more amplitude events * fix: input starting with . for swap tab * feat: hide percent change when below 1% * feat: market price now shows 0% * chore: updated tooltips * chore: localizations * fix: spacing * fix: removed unused localization * fix: display values for new quote type * chore: localizations * fix: in given out refetch dropped to 10 seconds * fix: sell tab non focused display * feat: dynamic slippage for in-given-out * feat: added inGivenOut feature flag * fix: adjusted slippage resetting * fix: removed unused file * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: renamed slippage variable and fixed comments * fix: added handler for alternate slippage error * feat: added handlers for slippage over balance * fix: loading state for buy/sell tab * refactor: moved amount with slippage calculation to a hook * refactor: cleaned up nonFocusedDisplayAmount * fix: reinstated balance query for exact amount out * fix: added number formatting for swap tab inputs * feat: added OCT to in given out * chore: localizations * refactor: useQueryRouterBestQuote changes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * [In Given Out]: Feature Flag (#3781) * fix: improved inGivenOut FF disabled behavior * fix: clear inputs on swap * fix: added cases for if user has input and in given out ff is disabled * fix: swap inputs on empty value * Swap more OSMO to ATOM (#3782) * (Deposit/Withdraw) Display Keplr EVM correctly (#3771) * [In Given Out]: Default input adjustments (#3784) * fix: button disabled for limit * feat: default display for buy/sell tab * refactor: wrapped updating code in useEffect * fix: loading state for button * feat: added slippage warning for default too high (#3787) * Mattupham/fe 784 portfolio v2 open orders / limit orders (#3786) * open orders * Add base values for limit orders * Add open orders * Clean up styles * Clean up styles * Base i18n * i18n * Update quote asset * fix: remove logs and correct limit input amount (#3788) * feat: add account address to txn scan endpoint (#3783) * Restrict Orderbook Amount (#3791) * fix: limited orderbook pools for orders query * fix: restrict pools from SQS rather than in orderbook router --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: yakuramori <[email protected]> Co-authored-by: Jose Felix <[email protected]> Co-authored-by: Matt Upham <[email protected]> Co-authored-by: PaddyMc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change:
Enables slippage warning when dynamic slippage goes too high