D/W: check all denoms with lower case

[jonator]

What is the purpose of the change:

Linear Task

In the IBC provider, the gas token was checked with only one comparison denom being cast to lower case. This was generally not an issue because we would then query the generated chain list to check for gas tokens there. However, for some Osmosis gas tokens, this caused the queried gas token denom to not be found in the asset list.

Brief Changelog

• Cast denoms to lower case before comparison for getting Osmosis gas token in IBC bridge provider

Testing and Verifying

Tested locally

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2024 2:41am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Aug 28, 2024 2:41am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Aug 28, 2024 2:41am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 28, 2024 2:41am
osmosis-testnet	⬜️ Ignored (Inspect)			Aug 28, 2024 2:41am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes across various files primarily focus on enhancing the robustness of asset lookups by implementing case-insensitive comparisons for asset denominations and addresses. Additionally, several components and functions have been refactored to remove unnecessary interface implementations, streamline exports, and simplify error handling and query management. These modifications affect the public API and internal logic of the modules, leading to a more concise and maintainable codebase.

Changes

Files	Change Summary
packages/bridge/src/ibc/index.ts packages/bridge/src/nitro/index.ts packages/bridge/src/squid/index.ts	Enhanced case-insensitivity in asset lookups by applying toLowerCase() for string comparisons involving asset denominations and addresses.
packages/pools/src/router/__tests__/pool.ts packages/pools/src/router/routes.ts packages/pools/src/router/types.ts	Removed implementation of TokenOutGivenInRouter interface from multiple classes and eliminated the interface itself, simplifying the routing functionality.
packages/server/src/queries/complex/index.ts packages/server/src/queries/complex/pools/index.ts packages/server/src/queries/complex/pools/providers/index.ts	Adjusted exports by removing specific modules, which alters the public API and may affect dependent components.
packages/server/src/queries/index.ts packages/server/src/queries/sidecar/index.ts	Introduced new exports to enhance module interfaces, allowing additional functionalities to be accessible.
packages/server/src/queries/osmosis/poolmanager/pools.ts	Renamed queryPools function to queryPoolsChain, altering how external components reference this function.
packages/server/src/queries/sidecar/router.ts	Added getSidecarRouter function for instantiating OsmosisSidecarRemoteRouter, which has been restructured to accept a sidecarBaseUrl parameter.
packages/trpc/src/__tests_e2e__/swap-router.spec.ts	Streamlined test cases by removing redundant parameters and potentially outdated tests related to swapRouter functionality.
packages/trpc/src/swap.ts	Removed preferredRouter parameter from the swapRouter input schema, simplifying the routing logic by directly utilizing getSidecarRouter.
packages/web/components/swap-tool/alt.tsx packages/web/components/swap-tool/index.tsx packages/web/hooks/limit-orders/use-place-limit.ts	Removed router property from various components, indicating a shift in how routing information is managed.
packages/web/hooks/use-feature-flags.ts	Streamlined AvailableFlags type by removing specific flags and adjusting the defaultFlags object and function declaration for clarity.
packages/web/hooks/use-swap.tsx	Modified error handling and query management in useSwap and useQueryRouterBestQuote functions, enhancing clarity and simplifying the data handling process.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SwapRouter
    participant SidecarRouter

    User->>SwapRouter: Initiate Swap
    SwapRouter->>SidecarRouter: Get Sidecar Router
    SidecarRouter-->>SwapRouter: Return Router Instance
    SwapRouter-->>User: Provide Swap Confirmation

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.