Deposit/Withdraw: IBC provider: fix Osmosis gas asset list denom check

[jonator]

What is the purpose of the change:

Linear Task

In the IBC provider, the gas token was checked with only one comparison denom being cast to lower case. This was generally not an issue because we would then query the generated chain list to check for gas tokens there. However, for some Osmosis gas tokens, this caused the queried gas token denom to not be found in the asset list. With that, this bug would only be present if the generated asset list also does not contain the denom.

Brief Changelog

• Cast denoms to lower case before comparison for getting Osmosis gas token in IBC bridge provider

Testing and Verifying

Tested locally

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2024 2:51am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Aug 28, 2024 2:51am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Aug 28, 2024 2:51am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 28, 2024 2:51am
osmosis-testnet	⬜️ Ignored (Inspect)			Aug 28, 2024 2:51am

[coderabbitai]

Walkthrough

The changes involve modifying the asset comparison logic in multiple bridge provider classes to ensure case-insensitive matching of asset identifiers. This includes adjustments in the IbcBridgeProvider, NitroBridgeProvider, and SquidBridgeProvider classes, where comparisons of asset properties now utilize a lowercase transformation to prevent mismatches due to varying letter cases.

Changes

File Path	Change Summary
packages/bridge/src/ibc/index.ts	Enhanced case-insensitive matching for asset denomination comparisons in IbcBridgeProvider.
packages/bridge/src/nitro/index.ts	Improved case-insensitivity in address comparison within the setTokenParam function of NitroBridgeProvider.
packages/bridge/src/squid/index.ts	Modified asset lookup logic for case-insensitive comparison in SquidBridgeProvider.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d2b500c and 5650702.

Files selected for processing (3)

• packages/bridge/src/ibc/index.ts (3 hunks)
• packages/bridge/src/nitro/index.ts (1 hunks)
• packages/bridge/src/squid/index.ts (1 hunks)

Additional comments not posted (5)

packages/bridge/src/nitro/index.ts (1)

122-125: LGTM!

The case-insensitive comparison improves robustness.

The code changes are approved.

packages/bridge/src/ibc/index.ts (3)

102-105: LGTM!

The case-insensitive comparison improves robustness.

The code changes are approved.

---

230-232: LGTM!

The case-insensitive comparison improves robustness.

The code changes are approved.

---

246-247: LGTM!

The case-insensitive comparison improves robustness.

The code changes are approved.

packages/bridge/src/squid/index.ts (1)

318-321: LGTM!

The case-insensitive comparison improves robustness.

The code changes are approved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.