sqs pools provider: handle empty poolIDs array

[jonator]

What is the purpose of the change:

Linear Task

We were passing user pool IDs to the SQS pools provider to only fetch the pools for the user.

However, if the user had no pools this would cause an empty array to be passed to SQS pools provider.

The problem arose because SQS would return all pools since the pool IDs list would be empty. This would cause pools to be returned as if they were user pools.

Brief Changelog

• Explicitly return empty array if poolIDs array is present with no elements

Testing and Verifying

Tested locally

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2024 4:31am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Aug 28, 2024 4:31am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Aug 28, 2024 4:31am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 28, 2024 4:31am
osmosis-testnet	⬜️ Ignored (Inspect)			Aug 28, 2024 4:31am

[coderabbitai]

Walkthrough

The changes involve modifications to two functions, getPoolsFromSidecar and getUserPools. The getPoolsFromSidecar function now includes a guard clause to return an empty array if no pool IDs are available. The getUserPools function simplifies the retrieval of pool data by removing a timeout wrapper, allowing it to directly await the results from the getPools function, streamlining the process.

Changes

Files	Change Summary
.../sidecar.ts and .../user.ts	- getPoolsFromSidecar: Added a guard clause to return an empty array if poolIds is undefined or an empty array. - getUserPools: Removed a timeout wrapper, simplifying the call to getPools and adjusting variable naming in the mapping process.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9fddb5 and 53bd7ac.

Files selected for processing (2)

• packages/server/src/queries/complex/pools/providers/sidecar.ts (1 hunks)
• packages/server/src/queries/complex/pools/user.ts (1 hunks)

Additional comments not posted (2)

packages/server/src/queries/complex/pools/providers/sidecar.ts (1)

39-40: LGTM!

The guard clause correctly handles the edge case where poolIds is an empty array, ensuring the function returns an empty array without unnecessary processing.

The code changes are approved.

packages/server/src/queries/complex/pools/user.ts (1)

69-72: LGTM!

The removal of the timeout wrapper simplifies the function and makes it more straightforward. The direct call to getPools without the timeout is efficient and reduces complexity.

The code changes are approved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ValarDragon]

Yikes, thanks for fixing these