Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Limit orders and swaps #3817

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Split Limit orders and swaps #3817

merged 2 commits into from
Sep 2, 2024

Conversation

yury-dubinin
Copy link
Contributor

@yury-dubinin yury-dubinin commented Sep 2, 2024

What is the purpose of the change:

  • Split limit orders and swaps monitoring
  • Run swaps every 25 minutes to avoid collision with limits
  • Run limits every hour

@yury-dubinin yury-dubinin self-assigned this Sep 2, 2024
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 6:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:00pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:00pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Sep 2, 2024 6:00pm
osmosis-testnet ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:00pm

Copy link
Contributor

coderabbitai bot commented Sep 2, 2024

Walkthrough

The changes involve the addition of a new GitHub Actions workflow for monitoring synthetic limit orders across different geographical regions (EU, SG, and US) and the modification of an existing workflow to focus on synthetic swaps instead of general geo tests. The new workflow includes hourly testing jobs with a cleanup process, while the modified workflow reduces its scope by removing specific trade test jobs and adjusting the scheduling frequency.

Changes

Files Change Summary
.github/workflows/monitoring-limit-geo-e2e-tests.yml New workflow added for monitoring synthetic limit orders across EU, SG, and US with hourly execution, testing jobs for each region, artifact uploads on failure, and Slack notifications.
.github/workflows/monitoring-swap-geo-e2e-tests.yml Workflow name changed to focus on swaps monitoring, cron schedule adjusted from every 20 minutes to every 25 minutes, removal of frontend trade test jobs, and simplification of the delete-deployments job dependencies.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7668254 and de7d5a0.

Files selected for processing (1)
  • .github/workflows/monitoring-swap-geo-e2e-tests.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/monitoring-swap-geo-e2e-tests.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

to avoid collision with limits
@yury-dubinin yury-dubinin merged commit dea7c21 into stage Sep 2, 2024
33 checks passed
@yury-dubinin yury-dubinin deleted the up-monitorin-frequency branch September 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants