Updated Keplr wallet and more time for pools to load

[yury-dubinin]

What is the purpose of the change:

• Updated Keplr wallet version
• wait for OSMO/USDC pool for 10 seconds

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2024 9:51am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Sep 4, 2024 9:51am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Sep 4, 2024 9:51am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Sep 4, 2024 9:51am
osmosis-testnet	⬜️ Ignored (Inspect)			Sep 4, 2024 9:51am

[coderabbitai]

Walkthrough

The changes include updates to the .gitignore file to exclude a specific directory related to the MetaMask extension, modifications to the PoolsPage class to adjust loading times for pools, and enhancements to the UnzipExtension class to update the Keplr extension path and add a method for handling the MetaMask extension extraction.

Changes

File	Change Summary
.gitignore	Added packages/web/e2e/metamask-extension-manifest/ to ignore list.
packages/web/e2e/pages/pools-page.ts	Adjusted loading wait times and added comments regarding pool loading expectations.
packages/web/e2e/unzip-extension.ts	Updated Keplr extension zip file path and added getPathToMetaMaskExtension() method for extraction.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ed391f2 and bedfedd.

Files ignored due to path filters (1)

• packages/web/e2e/keplr-extension-manifest-v3-v0.12.125.zip is excluded by !**/*.zip, !**/*.zip

Files selected for processing (3)

• .gitignore (1 hunks)
• packages/web/e2e/pages/pools-page.ts (1 hunks)
• packages/web/e2e/unzip-extension.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• .gitignore

Additional comments not posted (3)

packages/web/e2e/unzip-extension.ts (2)

10-10: LGTM!

The code changes are approved.

---

17-27: LGTM!

The code changes are approved.

packages/web/e2e/pages/pools-page.ts (1)

30-35: LGTM! The changes improve the robustness of the test.

The modifications to the goto method enhance the interaction with the pools page by:

• Adjusting the wait time to 2 seconds after navigating to the pools page.
• Adding a comment to clarify that pools may sometimes take longer to load and setting the expectation for tokens to be loaded after 10 seconds.
• Explicitly waiting for a specific pool (ID "1464") to be ready by hovering over its locator with a timeout of 10 seconds.

These changes demonstrate a more flexible approach to handling loading times and improve the reliability of the test by ensuring that the necessary elements are loaded before proceeding.

Additional insights:

• The increased wait time of 10 seconds for the specific pool (ID "1464") suggests that it may have a longer loading time compared to other pools. This could be due to various factors such as the size of the pool, the complexity of its data, or network conditions.
• The comment provides valuable context for future maintainers, explaining the reasoning behind the increased wait time and setting clear expectations for the loading behavior.
• Consider monitoring the loading times of different pools and adjusting the wait times accordingly to optimize the balance between test reliability and execution speed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.