Do not log subsequent chart interaction events / Handle last event tracking

[mattupham]

What is the purpose of the change:

• chart interaction event was overloading amplitude, track last event and don't track multiple chart interaction events in a row

Linear Task

https://linear.app/osmosis/issue/FE-1090/portfolio-overloading-amplitude

Brief Changelog

• track last amplitude event

Testing and Verifying

tested multiple chart interactions, logged after check to ensure only one event was logged

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 10, 2024 1:29am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 1:29am
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 1:29am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Sep 10, 2024 1:29am
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 1:29am

[coderabbitai]

Walkthrough

The changes introduce a new function, getLastEvent, to the useAmplitudeAnalytics hook, which enhances event logging by preventing duplicate event logging in quick succession. This is achieved through the implementation of a Zustand store to manage the last logged event. The logEvent function is updated to call setLastEvent after logging an event, and the MenuItemContent component is modified to destructure getLastEvent alongside logEvent. Additionally, multiple new properties, including coinDenom, are added to the EventProperties type for improved event tracking.

Changes

File Path	Change Summary
packages/web/hooks/use-amplitude-analytics.ts	Added LastEvent and AmplitudeStore types, implemented Zustand store for tracking last event, modified logAmplitudeEvent to update last event, introduced logEvent and getLastEvent functions.
packages/web/components/complex/portfolio/historical-chart.tsx	Added getLastEvent to useAmplitudeAnalytics return value to enhance event logging logic.
packages/web/components/main-menu.tsx	Updated destructuring in MenuItemContent to include getLastEvent, enhancing analytics interaction.
packages/web/config/analytics-events.ts	Added multiple properties including coinDenom to EventProperties type for improved event data structure.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (3)

packages/web/hooks/use-amplitude-analytics.ts (1)

37-37: Modification to logAmplitudeEvent function is aligned with PR objectives.

The addition of setLastEvent after logging ensures that only the last event is tracked, which is crucial for reducing logging overhead. Consider adding a debug log for the setLastEvent operation to aid in debugging and verification.

packages/web/components/complex/portfolio/historical-chart.tsx (1)

Line range hint 40-64: Effective use of getLastEvent to prevent duplicate event logging.

The integration of getLastEvent in the PortfolioHistoricalChart component is correctly implemented to prevent duplicate logging of the same event. Consider adding a comment explaining why this check is necessary, as it helps maintain code clarity and aids future maintenance.

packages/web/components/main-menu.tsx (1)

177-177: Proper integration of getLastEvent in MenuItemContent.

The addition of getLastEvent alongside logEvent in the destructuring from useAmplitudeAnalytics is correctly implemented. It's recommended to document the potential uses of getLastEvent to guide future development and ensure clarity in its application.