Mattupham/fe 1077 v26 fe tasks #3843
Conversation
…count' into mattupham/fe-1077-v26-fe-tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
Warning Rate limit exceeded@mattupham has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 59 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request introduces multiple changes across various files, focusing on renaming properties related to authenticators for improved clarity, updating the commit hash for the Osmosis protocol, and modifying the signing logic in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This reverts commit 94f041a.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- packages/proto-codecs/scripts/get-proto.sh (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/smartaccount/v1beta1/tx.ts (9 hunks)
- packages/stores/src/account/base.ts (1 hunks)
- packages/stores/src/account/osmosis/index.ts (3 hunks)
- packages/stores/src/account/utils.ts (1 hunks)
- packages/tx/src/message-composers/osmosis/authenticator.ts (2 hunks)
- packages/web/components/transactions/transaction-row.tsx (1 hunks)
- packages/web/hooks/mutations/one-click-trading/tests/use-create-one-click-trading-session.spec.ts (2 hunks)
- packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx (2 hunks)
Files skipped from review due to trivial changes (5)
- packages/proto-codecs/src/codegen/osmosis/smartaccount/v1beta1/tx.ts
- packages/stores/src/account/osmosis/index.ts
- packages/tx/src/message-composers/osmosis/authenticator.ts
- packages/web/hooks/mutations/one-click-trading/tests/use-create-one-click-trading-session.spec.ts
- packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx
Additional comments not posted (3)
packages/proto-codecs/scripts/get-proto.sh (1)
9-9: Verify the impact of updating the Osmosis commit hash.The change looks good. The
OSMOSIS_COMMIT_HASHvariable is updated to a new commit hash, suggesting an update to the version of the Osmosis protocol being used.Please ensure that:
- The new commit hash is the intended version to be used.
- The update does not introduce any compatibility issues with the dependent code.
You can run the following script to verify the usage of the
OSMOSIS_COMMIT_HASHvariable and its potential impact:packages/stores/src/account/utils.ts (1)
144-146: LGTM!The change to
defaultTimeoutHeightOffsetmaintains the same total timeout duration of 150 seconds while updating the calculation to reflect a 2-second block time. The comment is also updated to match the new calculation.This change is consistent with the AI-generated summary and improves the code by aligning it with the current assumptions about block time.
packages/web/components/transactions/transaction-row.tsx (1)
40-40: LGTM!Making the
hashproperty optional in theTransactionRowinterface provides flexibility in creating instances without necessarily providing ahashvalue. This change aligns with the AI-generated summary.Note that this change may impact the logic where
TransactionRowis utilized, as developers will need to account for the possibility thathashmay beundefined. Ensure that the codebase is updated to handle this appropriately.
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range and nitpick comments (3)
packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/v1beta1/gov.ts (2)
120-122: Consider removing the deprecatedexponentAtPriceOnefield.The
exponentAtPriceOnefield is being added to thePoolRecordinterface with a deprecation notice. To avoid confusion and prevent its usage, it's recommended to remove the field entirely instead of just marking it as deprecated.
133-135: Consider removing the deprecatedexponent_at_price_onefield.The
exponent_at_price_onefield is being added to thePoolRecordAminointerface with a deprecation notice. To avoid confusion and prevent its usage, it's recommended to remove the field entirely instead of just marking it as deprecated.packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.ts (1)
303-303: Consider replacing empty interfaces with type aliases.The static analysis tool has flagged several empty interfaces that could be replaced with type aliases for a cleaner and more idiomatic TypeScript code. Consider replacing the following interfaces with type aliases:
MsgRecoverClientResponseMsgIBCSoftwareUpgradeResponseMsgUpdateParamsResponseThis change does not affect the functionality but improves code quality and readability.
Apply this diff to replace the empty interfaces with type aliases:
-export interface MsgRecoverClientResponse {} +export type MsgRecoverClientResponse = Record<string, never>; -export interface MsgIBCSoftwareUpgradeResponse {} +export type MsgIBCSoftwareUpgradeResponse = Record<string, never>; -export interface MsgUpdateParamsResponse {} +export type MsgUpdateParamsResponse = Record<string, never>;Also applies to: 309-309, 315-315, 365-365, 371-371, 377-377, 414-414, 420-420
Tools
Biome
[error] 303-303: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/proto-codecs/scripts/generated/package-types.tsis excluded by!**/generated/**
Files selected for processing (36)
- packages/proto-codecs/scripts/get-proto.sh (2 hunks)
- packages/proto-codecs/src/codegen/cosmos/bundle.ts (1 hunks)
- packages/proto-codecs/src/codegen/cosmwasm/bundle.ts (2 hunks)
- packages/proto-codecs/src/codegen/cosmwasm/wasm/v1/ibc.ts (2 hunks)
- packages/proto-codecs/src/codegen/cosmwasm/wasm/v1/tx.ts (3 hunks)
- packages/proto-codecs/src/codegen/gogoproto/bundle.ts (1 hunks)
- packages/proto-codecs/src/codegen/google/bundle.ts (1 hunks)
- packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/authz.ts (9 hunks)
- packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.amino.ts (1 hunks)
- packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.registry.ts (4 hunks)
- packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.ts (6 hunks)
- packages/proto-codecs/src/codegen/ibc/bundle.ts (3 hunks)
- packages/proto-codecs/src/codegen/ibc/core/client/v1/client.ts (8 hunks)
- packages/proto-codecs/src/codegen/ibc/core/client/v1/genesis.ts (3 hunks)
- packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.amino.ts (2 hunks)
- packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.registry.ts (4 hunks)
- packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.ts (6 hunks)
- packages/proto-codecs/src/codegen/osmosis/bundle.ts (5 hunks)
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/params.ts (3 hunks)
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.amino.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.ts (2 hunks)
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/v1beta1/gov.ts (9 hunks)
- packages/proto-codecs/src/codegen/osmosis/cosmwasmpool/v1beta1/model/tx.ts (2 hunks)
- packages/proto-codecs/src/codegen/osmosis/gamm/v1beta1/genesis.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/gamm/v1beta1/params.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/taker_fee_share.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.amino.ts (2 hunks)
- packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.registry.ts (5 hunks)
- packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.ts (6 hunks)
- packages/proto-codecs/src/codegen/osmosis/superfluid/tx.amino.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/superfluid/tx.ts (2 hunks)
- packages/proto-codecs/src/codegen/osmosis/valsetpref/v1beta1/tx.amino.ts (1 hunks)
- packages/proto-codecs/src/codegen/osmosis/valsetpref/v1beta1/tx.ts (2 hunks)
- packages/proto-codecs/src/codegen/tendermint/bundle.ts (1 hunks)
- packages/web/components/one-click-trading/one-click-trading-settings.tsx (2 hunks)
- packages/web/components/one-click-trading/one-click-trading-welcome-back.tsx (0 hunks)
Files not reviewed due to no reviewable changes (1)
- packages/web/components/one-click-trading/one-click-trading-welcome-back.tsx
Files skipped from review due to trivial changes (10)
- packages/proto-codecs/src/codegen/cosmwasm/bundle.ts
- packages/proto-codecs/src/codegen/cosmwasm/wasm/v1/tx.ts
- packages/proto-codecs/src/codegen/ibc/bundle.ts
- packages/proto-codecs/src/codegen/osmosis/bundle.ts
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.amino.ts
- packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.ts
- packages/proto-codecs/src/codegen/osmosis/cosmwasmpool/v1beta1/model/tx.ts
- packages/proto-codecs/src/codegen/osmosis/superfluid/tx.amino.ts
- packages/proto-codecs/src/codegen/osmosis/superfluid/tx.ts
- packages/proto-codecs/src/codegen/osmosis/valsetpref/v1beta1/tx.ts
Files skipped from review as they are similar to previous changes (1)
- packages/proto-codecs/scripts/get-proto.sh
Additional context used
Biome
packages/proto-codecs/src/codegen/cosmwasm/wasm/v1/ibc.ts
[error] 82-82: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 88-88: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 94-94: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.ts
[error] 158-158: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 167-167: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 176-176: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.ts
[error] 303-303: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 309-309: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 315-315: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 365-365: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 371-371: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 377-377: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 414-414: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 420-420: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.ts
[error] 307-307: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 312-312: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 317-317: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 351-351: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 356-356: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
[error] 361-361: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
Additional comments not posted (72)
packages/proto-codecs/src/codegen/gogoproto/bundle.ts (2)
4-4: LGTM!The change in the spread operator is consistent with the import statement change.
2-2: Verify the impact of the change in the./gogomodule.The import alias has been changed from
_69to_71, suggesting that the source module being imported from./gogohas been updated or replaced. This change alters the reference point for the properties and methods being spread into thegogoprotoobject.Please ensure that the changes in the
./gogomodule do not introduce any breaking changes or unintended side effects on thegogoprotoobject and the codebase.Run the following script to verify the impact:
Verification successful
Verified: Import alias change has no significant impact
The change in the import alias from
_69to_71inpackages/proto-codecs/src/codegen/gogoproto/bundle.tshas been verified and does not have a significant impact on the codebase. Thegogo.tsfile is essentially empty, containing onlyexport {};, which means thegogoprotoobject inbundle.tsis not affected by this change.The usage of
gogoprotoin other files is not directly related to this import change. This update appears to be a minor change, possibly due to code generation or reorganization, and does not introduce any breaking changes or unintended side effects on thegogoprotoobject and the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the change in the `./gogo` module on the `gogoproto` object and the codebase. # Test 1: Search for the usage of the `gogoproto` object in the codebase. rg --type typescript -A 5 $'gogoproto' # Test 2: Search for the usage of the properties and methods from the `./gogo` module in the codebase. ast-grep --lang typescript --pattern $'import { $$$ } from "./gogo"'Length of output: 144
Script:
#!/bin/bash # Description: Verify the impact of the change in the `./gogo` module on the `gogoproto` object and the codebase. # Test 1: Search for the usage of the `gogoproto` object in TypeScript files fd -e ts -e tsx | xargs grep -n "gogoproto" -A 5 # Test 2: Search for imports from "./gogo" in TypeScript files ast-grep --lang typescript --pattern 'import $_ from "./gogo"' # Test 3: Check the content of the gogo.ts file cat packages/proto-codecs/src/codegen/gogoproto/gogo.ts # Test 4: List all files in the gogoproto directory ls -l packages/proto-codecs/src/codegen/gogoproto/Length of output: 4742
packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.amino.ts (1)
9-13: LGTM!The addition of the
MsgUpdateParamsentry to theAminoConverterobject is consistent with the existing structure and follows the expected naming conventions. This change expands the functionality of theAminoConverterto support the conversion of theMsgUpdateParamsmessage type, enabling the updating of module parameters through transactions within the IBC transfer module.packages/proto-codecs/src/codegen/google/bundle.ts (2)
2-8: LGTM!The reorganization of import statements and the addition of new imports for
emptyandtimestampfrom theprotobufdirectory improve the modular structure of the code and enhance the functionality of theprotobufnamespace.
13-19: LGTM!The use of the spread operator to include the newly imported modules in the
protobufnamespace is a clean and concise way to ensure that the namespace includes all the necessary entities.packages/proto-codecs/src/codegen/tendermint/bundle.ts (4)
2-3: LGTM!The import statements for the
cryptomodule have been updated to reference the latest files or modules. The functionality of the module is likely unchanged, as the import names remain the same.
4-8: LGTM!The import statements for the
typesmodule have been updated and expanded to include additional files or modules. The functionality of the existingtypesmodules is likely unchanged, as the import names remain the same. The new imports (_84and_85) suggest that new types or modules have been added to thetypesnamespace, which may provide additional functionality or improve the organization of the code.
9-9: LGTM!The import statement for the
versionmodule has been updated to reference the latest file or module. The functionality of the module is likely unchanged, as the import name remains the same.
14-23: LGTM!The structure of the
tendermintnamespace has been updated to reflect the changes in the import statements. Thecrypto,types, andversionobjects now reference the updated import names, ensuring that the correct files or modules are being referenced within the namespace. The functionality of these objects is likely unchanged, as the import names remain the same.packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.amino.ts (3)
32-36: LGTM!The addition of the
MsgRecoverClientmessage type to theAminoConverterobject is consistent with the existing code structure and conventions. TheaminoTypeand conversion functions are properly defined.
37-41: LGTM!The addition of the
MsgIBCSoftwareUpgrademessage type to theAminoConverterobject is consistent with the existing code structure and conventions. TheaminoTypeand conversion functions are properly defined.
42-46: LGTM!The addition of the
MsgUpdateParamsmessage type to theAminoConverterobject is consistent with the existing code structure and conventions. TheaminoTypeand conversion functions are properly defined.packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.registry.ts (5)
4-4: LGTM!The import statement is syntactically correct and necessary for the subsequent usage of
MsgUpdateParamsin the file.
7-7: LGTM!The addition of the new entry to the
registryarray is syntactically correct and follows the existing pattern. The type URL and the corresponding type are correctly specified.
22-27: LGTM!The addition of the new method
updateParamsto theencodedproperty of theMessageComposerobject is syntactically correct and follows the existing pattern. The type URL and the encoding logic are correctly specified.
36-41: LGTM!The addition of the new method
updateParamsto thewithTypeUrlproperty of theMessageComposerobject is syntactically correct and follows the existing pattern. The type URL is correctly specified.
50-55: LGTM!The addition of the new method
updateParamsto thefromPartialproperty of theMessageComposerobject is syntactically correct and follows the existing pattern. The type URL and the partial value logic are correctly specified.packages/proto-codecs/src/codegen/cosmos/bundle.ts (6)
25-26: LGTM!The changes to the
v1beta1namespace incosmos.authlook good. The use of the spread operator to include the contents of the newly imported modules is a valid approach to restructure the namespace.
33-36: LGTM!The changes to the
v1beta1namespace incosmos.banklook good. The use of the spread operator to include the contents of the newly imported modules is a valid approach to restructure the namespace.
42-42: LGTM!The changes to the
v1beta1namespace incosmos.base.querylook good. The use of the spread operator to include the contents of the newly imported module is a valid approach to restructure the namespace.
53-56: LGTM!The changes to the
v1beta1namespace incosmos.stakinglook good. The use of the spread operator to include the contents of the newly imported modules is a valid approach to restructure the namespace.
61-64: LGTM!The changes to the
v1beta1namespace incosmos.upgradelook good. The use of the spread operator to include the contents of the newly imported modules is a valid approach to restructure the namespace.
2-20: Verify the impact of the import changes on the codebase.The import statements have been modified to reference different versions of the modules, which could impact the functionality of the code that relies on these imports. Please ensure that the changes are consistent with the intended behavior and do not introduce any breaking changes.
Run the following script to search for potential usage of the modified imports:
Verification successful
The import changes appear to be safe, but manual verification is recommended.
The search results indicate that the modified imports (
cosmos.auth.v1beta1,cosmos.bank.v1beta1, etc.) are widely used throughout the codebase. However, there were no direct references found to the specific import aliases (_57, _58, etc.) that were changed in the file under review.This suggests that the changes are primarily organizational and don't introduce new functionality or breaking changes. The modules and their versions (v1beta1) remain consistent, which further supports this conclusion.
While the automated checks don't reveal any immediate issues, it's always a good practice to manually verify the changes, especially in critical areas of the codebase that interact with these Cosmos SDK modules.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for usage of the modified imports in the codebase. # Test: Search for references to the modified imports. rg --type typescript -A 5 $'cosmos\.(auth|bank|base|staking|upgrade)\.v1beta1'Length of output: 114
Script:
#!/bin/bash # Description: Search for usage of the modified imports in the codebase using a more generic approach. # Find TypeScript files and search for references to the modified imports fd -e ts -e tsx | xargs rg -n -A 3 '(auth|bank|base|staking|upgrade)\.v1beta1' # Additionally, search for any direct references to the imported modules fd -e ts -e tsx | xargs rg -n -A 3 '(_57|_58|_59|_60|_61|_62|_113|_116|_63|_64|_65|_66|_67|_68|_114|_117|_69|_115|_118)\.'Length of output: 109061
packages/proto-codecs/src/codegen/osmosis/valsetpref/v1beta1/tx.amino.ts (1)
43-43: Verify the impact of theaminoTypechange.The change aligns the
aminoTypewith the naming convention used for other message types in the Osmosis protocol, which is a good practice.To ensure this change doesn't introduce any compatibility issues, please verify the following:
- The new
aminoTypeis consistently used across the codebase.- The change doesn't break any existing functionality or integrations with external systems or libraries that may rely on the previous
aminoType.You can use the following script to search for occurrences of the old and new
aminoTypein the codebase:Verification successful
aminoType change is correctly implemented and consistent
The change from "osmosis/valsetpref/delegate-bonded-tokens" to "osmosis/MsgDelegateBondedTokens" has been correctly implemented in the
tx.amino.tsfile. The new aminoType is consistently used in bothtx.amino.tsandtx.tsfiles for the message type, which is a good practice.However, please note:
- The old aminoType string "osmosis/valsetpref/delegate-bonded-tokens-response" is still present in
packages/proto-codecs/src/codegen/osmosis/valsetpref/v1beta1/tx.ts, but it's used for a response type, not the message type itself.- Consider updating this response type to maintain consistency with the new naming convention if appropriate.
The change appears to be isolated to the MsgDelegateBondedTokens message and doesn't affect other parts of the codebase, reducing the risk of unintended side effects.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash echo "Searching for old aminoType..." rg --type typescript --type javascript --type json '"osmosis/valsetpref/delegate-bonded-tokens"' echo "Searching for new aminoType..." rg --type typescript --type javascript --type json '"osmosis/MsgDelegateBondedTokens"'Length of output: 399
Script:
#!/bin/bash echo "Searching for old aminoType (partial match)..." rg -i "osmosis/valsetpref/delegate-bonded-tokens" echo "Searching for new aminoType (partial match)..." rg -i "osmosis/MsgDelegateBondedTokens" echo "Listing all files with 'aminoType' (case-insensitive)..." rg -il "aminotype"Length of output: 2570
packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.amino.ts (2)
37-41: LGTM!The new message type
MsgSetTakerFeeShareAgreementForDenomis correctly added to theAminoConverterobject, following the existing pattern. The amino type string and conversion methods are properly defined.
42-46: LGTM!The new message type
MsgSetRegisteredAlloyedPoolis correctly added to theAminoConverterobject, following the existing pattern. The amino type string and conversion methods are properly defined.packages/proto-codecs/src/codegen/osmosis/gamm/v1beta1/params.ts (5)
1-7: LGTM!The import statements are correctly defined and follow the proper syntax. The imported dependencies are relevant to the functionality of the file.
8-11: LGTM!The
Paramsinterface is correctly defined with the appropriate propertypoolCreationFeeof typeCoin[]. The interface is exported, making it accessible from other modules.
12-27: LGTM!The
ParamsProtoMsg,ParamsAmino,ParamsAminoMsg, andParamsSDKTypeinterfaces are correctly defined with the appropriate properties and types. These interfaces are used for encoding and decodingParamsobjects in different formats and are exported, making them accessible from other modules.
28-32: LGTM!The
createBaseParamsfunction is correctly defined and returns aParamsobject with the appropriate initial value for thepoolCreationFeeproperty.
33-105: LGTM!The
Paramsobject and its methods for encoding, decoding, and convertingParamsobjects are correctly defined and follow the proper syntax. The methods handle the necessary operations using the appropriate dependencies and types.packages/proto-codecs/src/codegen/ibc/core/client/v1/tx.registry.ts (4)
6-7: LGTM!The import statements for the new message types
MsgIBCSoftwareUpgradeandMsgRecoverClientare syntactically correct.
10-20: LGTM!The new message type
MsgUpdateParamsis imported correctly, and all three new message types are properly registered in theregistryarray with their respective typeUrls.
53-70: LGTM!The new methods
recoverClient,iBCSoftwareUpgrade, andupdateClientParamsare implemented correctly in theencodedsection of theMessageComposer. They follow the same pattern as the existing methods and facilitate the encoding of messages for the new types.
Line range hint
97-158: LGTM!The new methods
recoverClient,iBCSoftwareUpgrade, andupdateClientParamsare implemented correctly in both thewithTypeUrlandfromPartialsections of theMessageComposer. They follow the same pattern as the existing methods and ensure that the new message types can be utilized in the same manner as existing message types.packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.registry.ts (4)
6-7: LGTM!The new message types are correctly imported from the
./txmodule.
28-35: LGTM!The new message types are correctly registered in the
registryarray with their corresponding type URLs.
74-88: LGTM!The new methods in the
MessageComposer.encodedobject correctly encode the new message types using theencodemethod from the generated protobuf classes. The encoded messages are returned with their corresponding type URLs.
121-129: LGTM!The new methods in the
MessageComposer.withTypeUrlandMessageComposer.fromPartialobjects correctly handle the new message types. ThewithTypeUrlmethods return the message types with their corresponding type URLs, and thefromPartialmethods create the message types from partial data using thefromPartialmethod from the generated protobuf classes.Also applies to: 130-135, 168-176, 177-182
packages/proto-codecs/src/codegen/osmosis/gamm/v1beta1/genesis.ts (1)
23-23: LGTM!The removal of the import statement for
Params,ParamsAmino, andParamsSDKTypeis consistent with the removal of theParamsinterface and associated methods. This change does not introduce any new issues or inconsistencies in the code.packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/authz.ts (4)
18-22: LGTM!The addition of the
allowedPacketDataproperty to theAllocationinterface enhances the functionality and control over packet data in IBC transfers. The comments clearly describe the purpose and behavior of the property.
38-42: Looks good!The
allowedPacketDataproperty is correctly added to theAllocationAminointerface, maintaining consistency with theAllocationinterface. The property is appropriately marked as optional in the Amino encoding.
54-54: Looks good!The
allowedPacketDataproperty is correctly added to theAllocationSDKTypeinterface, maintaining consistency with theAllocationinterface. The property type is appropriately defined as an array of strings.
95-95: Excellent work!The
allowedPacketDataproperty is consistently integrated throughout the code:
- Initialized as an empty array in the
createBaseAllocationfunction.- Included in the encoding and decoding logic of the
Allocationobject.- Handled correctly in the
fromPartial,fromAmino, andtoAminomethods.This ensures proper serialization, deserialization, and compatibility with different representations of the
Allocationobject.Also applies to: 116-118, 141-143, 158-158, 172-172, 193-197
packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/params.ts (3)
29-36: Deprecation notice added forauthorizedQuoteDenoms.The changes clearly mark the
authorizedQuoteDenomsfield as deprecated by:
- Updating the comment to include a "DEPRECATED" label.
- Adding a JSDoc-style
@deprecatedcomment above the field declaration.This provides a clear indication to developers that this field should not be used going forward.
Also applies to: 38-38
81-88: Deprecation notice added forauthorized_quote_denoms.The changes clearly mark the
authorized_quote_denomsfield as deprecated by:
- Updating the comment to include a "DEPRECATED" label.
- Adding a JSDoc-style
@deprecatedcomment above the field declaration.This is consistent with the deprecation of
authorizedQuoteDenomsin theParamsinterface and provides a clear indication to developers that this field should not be used going forward.Also applies to: 90-90
118-118: Deprecation notice added forauthorized_quote_denoms.The addition of the JSDoc-style
@deprecatedcomment above theauthorized_quote_denomsfield declaration clearly marks it as deprecated. This is consistent with the deprecation of the same field in theParamsandParamsAminointerfaces.packages/proto-codecs/src/codegen/cosmwasm/wasm/v1/ibc.ts (1)
Line range hint
81-394: LGTM!The rest of the code segment, including the implementation of the associated methods for encoding, decoding, and message format conversions, follows a consistent pattern and appears to be correct.
packages/proto-codecs/src/codegen/ibc/core/client/v1/genesis.ts (3)
24-28: Deprecation notice forcreateLocalhostproperty looks good!The deprecation comment clearly explains the reason for deprecation and provides guidance on the new behavior. Consider adding a note in the release changelog to inform developers about this change.
46-50: LGTM!The deprecation notice for the
create_localhostproperty in the Amino encoding is consistent with the deprecation in theGenesisStateinterface.
65-65: Looks good!The deprecation of the
create_localhostproperty in the SDK type is consistent with the deprecations in theGenesisStateandGenesisStateAminointerfaces.packages/web/components/one-click-trading/one-click-trading-settings.tsx (1)
Line range hint
408-435: LGTM!The conditional rendering logic for displaying the fee to disable one-click trading is implemented correctly. The
<SkeletonLoader>component is used appropriately to handle the loading state, and the fee amount and USD value are displayed based on the available data.packages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.ts (3)
12-14: LGTM!The addition of the
MsgUpdateParamsmessage type and related interfaces looks good. It follows the existing patterns in the file and enables updating the transfer parameters by an authorized signer.Also applies to: 119-593
318-320: Consider removing the emptyCoinfallback.Including the
tokenfield in the Amino encoding even if empty is good for consistency with the updatedMsgTransferAminointerface.However, based on the
MsgTransferinterface, thetokenfield seems to be always required. If that's the case, defaulting to an emptyCoinas fallback may not be necessary. Please verify if thetokenfield can be undefined here, and if not, consider removing the fallback.
60-60: Verify and update existing code usingMsgTransferAmino.The changes to make the
tokenandtimeout_heightfields required in theMsgTransferAminointerface are good as they align it with the coreMsgTransferinterface.However, this is a breaking change. Ensure that all existing code that uses
MsgTransferAminois updated to provide these fields.You can use the following script to find and review the usage of
MsgTransferAmino:Also applies to: 69-69
Verification successful
This script will search for
MsgTransferAminoin all TypeScript files. If no results are found, it will perform a broader search for any 'Amino' usage to help us understand the context better.
Changes to
MsgTransferAminoare self-contained, no widespread updates needed.The modifications to the
MsgTransferAminointerface are localized to the filepackages/proto-codecs/src/codegen/ibc/applications/transfer/v1/tx.ts. Our analysis shows that there are no direct usages of this interface in other parts of the codebase. The changes are handled internally through conversion methods likefromAmino,toAmino,fromAminoMsg, andtoAminoMsgwithin the same file.However, it's advisable to:
- Review the conversion methods (lines 281-336) to ensure they correctly handle the now-required
tokenandtimeout_heightfields.- Verify that any external interactions with the IBC transfer module are compatible with these changes, especially if they rely on the Amino encoding.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usage of `MsgTransferAmino` and review code to ensure # `token` and `timeout_height` fields are provided. # Find all TypeScript files that use `MsgTransferAmino` fd --type ts --exec rg MsgTransferAminoLength of output: 211
Script:
#!/bin/bash # Description: Find usage of `MsgTransferAmino` in TypeScript files # Find all TypeScript files and search for MsgTransferAmino fd -e ts | xargs rg 'MsgTransferAmino' -n # If no results are found, search for any 'Amino' usage as a fallback if [ $? -ne 0 ]; then echo "No direct usage of MsgTransferAmino found. Searching for any 'Amino' usage:" fd -e ts | xargs rg 'Amino' -n fiLength of output: 891
packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/taker_fee_share.ts (5)
20-33: LGTM!The
TakerFeeShareAgreementinterface is well-defined and follows TypeScript conventions. The comments provide a clear explanation of the purpose and functionality of the interface.
85-90: LGTM!The
TakerFeeSkimAccumulatorinterface is well-defined and follows TypeScript conventions. The comments provide a clear explanation of the purpose and functionality of the interface.
126-135: LGTM!The
AlloyContractTakerFeeShareStateinterface is well-defined and follows TypeScript conventions. The comments provide a clear explanation of the purpose and functionality of the interface, including an example scenario that helps in understanding the concept of adjusted taker fee share agreements within an alloyed asset pool.
183-284: LGTM!The
TakerFeeShareAgreementobject follows a consistent pattern for encoding, decoding, and conversion methods. The methods handle various formats and edge cases appropriately, and thetypeUrlproperty is correctly defined. There are no apparent issues with the object definition or its methods.
395-506: LGTM!The
AlloyContractTakerFeeShareStateobject follows a consistent pattern for encoding, decoding, and conversion methods. The methods handle various formats and edge cases appropriately, and thetypeUrlproperty is correctly defined. There are no apparent issues with the object definition or its methods.packages/proto-codecs/src/codegen/osmosis/concentratedliquidity/v1beta1/gov.ts (1)
146-147: Conditional inclusion of the deprecatedexponentAtPriceOnefield looks good.The encoding and decoding logic for the
exponentAtPriceOnefield has been updated to conditionally include the field based on its value. This change aligns with the deprecation notice and helps in transitioning away from the usage of the deprecated field. The conditional inclusion ensures that the field is only included when it has a non-empty value, which is a good approach.Also applies to: 519-519, 538-540, 565-567, 589-589, 604-609, 623-626
packages/proto-codecs/src/codegen/ibc/core/client/v1/client.ts (5)
129-134: LGTM!The
Heightinterface is well-defined with appropriate properties and types to represent the revision number and height of a client.
135-138: LGTM!The
HeightProtoMsginterface correctly represents the protobuf message type for theHeightinterface with the appropriatetypeUrlandvalueproperties.
151-156: LGTM!The
HeightAminointerface correctly represents the Amino encoding type for theHeightinterface with the appropriaterevision_numberandrevision_heightproperties.
178-185: LGTM!The
Paramsinterface correctly represents the set of IBC light client parameters with the appropriateallowedClientsproperty of typestring[].
Line range hint
208-333: Note the deprecation ofClientUpdateProposalandUpgradeProposalinterfaces.These interfaces are marked as deprecated. Please update any usages of these interfaces to the recommended alternatives:
- Use
MsgRecoverClientinstead ofClientUpdateProposal- Use
MsgIBCSoftwareUpgradeinstead ofUpgradeProposalpackages/proto-codecs/src/codegen/ibc/core/client/v1/tx.ts (3)
264-275: LGTM!The
MsgRecoverClientinterface is well-defined and includes all the necessary fields for recovering a frozen or expired client. The comments provide a clear explanation of its purpose.
316-332: Looks good!The
MsgIBCSoftwareUpgradeinterface is well-structured and includes the necessary fields for scheduling an IBC client upgrade via a governance proposal. The comments offer helpful context on the significance of theupgradedClientStatefield in facilitating a seamless upgrade process.
197-199: Deprecation handled appropriately.The
MsgSubmitMisbehaviourinterface has been properly marked as deprecated using the@deprecatedJSDoc tag. The comment advising to useMsgUpdateClientinstead offers clear guidance for developers.packages/proto-codecs/src/codegen/osmosis/poolmanager/v1beta1/tx.ts (3)
249-269: LGTM!The
MsgSetTakerFeeShareAgreementForDenominterface provides a clear and well-structured definition for the parameters required to set a taker fee share agreement. The properties cover all the necessary information, including the sender, denom, skim percentage, and skim address.
319-327: LGTM!The
MsgSetRegisteredAlloyedPoolinterface provides a clear and well-structured definition for the parameters required to register an alloyed pool. The properties cover the necessary information, including the sender's address and the pool ID.
362-406: LGTM!The updates to the
DenomPairTakerFeeinterface, replacing the deprecateddenom0anddenom1fields withtokenInDenomandtokenOutDenom, align with the shift towards uni-directional trading pairs. The changes are properly documented with@deprecatedJSDoc tags for the old fields, and the new fields provide clarity on the token denoms for the trading pair.
| * MsgUpdateParamsResponse defines the response structure for executing a | ||
| * MsgUpdateParams message. | ||
| */ | ||
| export interface MsgUpdateParamsResponse {} |
There was a problem hiding this comment.
Replace empty interfaces with type aliases.
The static analysis tool correctly flags the usage of empty interfaces MsgUpdateParamsResponse, MsgUpdateParamsResponseAmino, and MsgUpdateParamsResponseSDKType as an anti-pattern.
To improve the code quality, please replace these empty interfaces with type aliases. For example:
- export interface MsgUpdateParamsResponse {}
+ export type MsgUpdateParamsResponse = {};This makes the intent clearer without changing the behavior.
Also applies to: 167-167, 176-176
Tools
Biome
[error] 158-158: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
| sender: string; | ||
| pool_id: bigint; | ||
| } | ||
| export interface MsgSetRegisteredAlloyedPoolResponse {} |
There was a problem hiding this comment.
Use a type alias instead of an empty interface.
The MsgSetRegisteredAlloyedPoolResponse interface is empty, which is equivalent to {}. As suggested by the static analysis tool, it's recommended to use a type alias instead of an empty interface for better code clarity and to avoid confusion.
Consider applying this change:
-export interface MsgSetRegisteredAlloyedPoolResponse {}
+export type MsgSetRegisteredAlloyedPoolResponse = Record<string, never>;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export interface MsgSetRegisteredAlloyedPoolResponse {} | |
| export type MsgSetRegisteredAlloyedPoolResponse = Record<string, never>; |
Tools
Biome
[error] 351-351: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
| skim_percent: string; | ||
| skim_address: string; | ||
| } | ||
| export interface MsgSetTakerFeeShareAgreementForDenomResponse {} |
There was a problem hiding this comment.
Use a type alias instead of an empty interface.
The MsgSetTakerFeeShareAgreementForDenomResponse interface is empty, which is equivalent to {}. As suggested by the static analysis tool, it's recommended to use a type alias instead of an empty interface for better code clarity and to avoid confusion.
Consider applying this change:
-export interface MsgSetTakerFeeShareAgreementForDenomResponse {}
+export type MsgSetTakerFeeShareAgreementForDenomResponse = Record<string, never>;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export interface MsgSetTakerFeeShareAgreementForDenomResponse {} | |
| export type MsgSetTakerFeeShareAgreementForDenomResponse = Record<string, never>; |
Tools
Biome
[error] 307-307: An empty interface is equivalent to {}.
Safe fix: Use a type alias instead.
(lint/suspicious/noEmptyInterface)
| COSMOS_SDK_VERSION=$(awk -F '=>' '/github.com\/osmosis-labs\/cosmos-sdk/ {print $2}' .repos/osmosis/go.mod | awk '{print $NF}' | tr -d '\n') | ||
| # COSMOS_SDK_VERSION=$(awk '/github.com\/cosmos\/cosmos-sdk/ {print $2}' .repos/osmosis/go.mod | tr -d '=> ') | ||
| # COSMOS_SDK_VERSION=$(awk -F '=>' '/github.com\/osmosis-labs\/cosmos-sdk/ {print $2}' .repos/osmosis/go.mod | awk '{print $NF}' | tr -d '\n') | ||
| COSMOS_SDK_VERSION=v0.50.6-v26-osmo-2 |
There was a problem hiding this comment.
leave this hardcoded for now - there were issues with the script
| @@ -52,7 +56,8 @@ git -C .repos/ibc-go checkout $IBC_GO_VERSION | |||
| # WASMD PROTOS | |||
|
|
|||
| # Extract the Wasmd version from the go.mod file | |||
| WASMD_VERSION=$(awk '/github.com\/osmosis-labs\/wasmd/ {print $4}' .repos/osmosis/go.mod | awk '{print $NF}' | tr -d '\n') | |||
| # WASMD_VERSION=$(awk '/github.com\/osmosis-labs\/wasmd/ {print $4}' .repos/osmosis/go.mod | awk '{print $NF}' | tr -d '\n') | |||
| WASMD_VERSION=de7db0dc672e7beb201e06e7eb12b2de356ac7c9 | |||
There was a problem hiding this comment.
leave this hardcoded for now - there were issues with the script
| // To test chain upgrades easily on Edgenet, uncomment the flags below | ||
| // limitOrders: true, | ||
| // oneClickTrading: true, | ||
| // staking: true, |
There was a problem hiding this comment.
I left this in here for the future - had to toggle these a handful of times, this makes it easier
* Mattupham/fe 1067 portfolio v3 update 0 change values to be green and up (#3823) * add threshold updates * Clean up logs * [Limit Orders]: SQS Active Order Query (#3828) * fix: increased cache time and refetch interval for active orders * fix: even longer cache * fix: WIP batch query implementation * fix: longer delay between batches * fix: batch size/timing * fix: vercel max duration * fix: wired in sqs query for active orders * fix: build * fix: filled orders styling * fix: remove claimable orders test data * fix: further reduced queries * feat: moved orders query to passthrough * fix: moved active orders to local router * fix: altered orders cache to be more responsive * chore: post typing fixes for active orders sqs query * fix: reverted unnecessary changes * feat: removed pool restriction on orderbooks * Clean up formatter (#3829) * Clean up formatter * Remove log * update no price data * add pr notification yaml (#3830) Co-authored-by: Michael Millington <> * fix lint issue (#3832) * Handle PricePretty and Lint issue * add search from query param for earn (#3836) * Update search from query param * Do not log subsequent chart interaction events / Handle last event tracking (#3834) * Handle last event tracking * Clean up * Clean up types * Update event properties * Add types for event options * Fix lint * Update MATIC -> POL (#3835) * Update MATIC -> POL * Update tests * feat: feature flag for sqs active orders (#3837) * [Limit Orders]: Fix date display for order history (#3833) * fix: date display for order history * fix: undid feature flag changes * fix: typing issue * [Limit Orders]: Price to Tick Crash Handler (#3838) * fix: price to tick error handling * feat: added swap source to swap amplitude events --------- Co-authored-by: Matt Upham <[email protected]> * Update IBC overrides to use POL (#3839) * fix: date display for active orders from node (#3840) * Mattupham/fe 1077 v26 fe tasks (#3843) * feat: adding ledger support to 1CT * fix: make hash optional for TransactionRow type * Add timeout * Update default timeout height offset * Update OSMOSIS_COMMIT_HASH * Revert "(1CT) Add Ledger Coming Soon Copy (#3554)" This reverts commit 94f041a. * Remove ledger paragraph * Clean up paragraph spacing * Update protos * Temp commit - snapshot of working progress * Update 1ct session allowed functions * get feature flags ready for launch * Clean up for launch * remove log * Fix type issues related to telescope --------- Co-authored-by: ghost <[email protected]> * Less alerts from claim workflow (#3845) * Publish Stage (#3831) (#3846) * Mattupham/fe 1067 portfolio v3 update 0 change values to be green and up (#3823) * add threshold updates * Clean up logs * [Limit Orders]: SQS Active Order Query (#3828) * fix: increased cache time and refetch interval for active orders * fix: even longer cache * fix: WIP batch query implementation * fix: longer delay between batches * fix: batch size/timing * fix: vercel max duration * fix: wired in sqs query for active orders * fix: build * fix: filled orders styling * fix: remove claimable orders test data * fix: further reduced queries * feat: moved orders query to passthrough * fix: moved active orders to local router * fix: altered orders cache to be more responsive * chore: post typing fixes for active orders sqs query * fix: reverted unnecessary changes * feat: removed pool restriction on orderbooks * Clean up formatter (#3829) * Clean up formatter * Remove log * update no price data * add pr notification yaml (#3830) Co-authored-by: Michael Millington <> * fix lint issue (#3832) * Handle PricePretty and Lint issue * add search from query param for earn (#3836) * Update search from query param * Do not log subsequent chart interaction events / Handle last event tracking (#3834) * Handle last event tracking * Clean up * Clean up types * Update event properties * Add types for event options * Fix lint * Update MATIC -> POL (#3835) * Update MATIC -> POL * Update tests * feat: feature flag for sqs active orders (#3837) * [Limit Orders]: Fix date display for order history (#3833) * fix: date display for order history * fix: undid feature flag changes * fix: typing issue * [Limit Orders]: Price to Tick Crash Handler (#3838) * fix: price to tick error handling * feat: added swap source to swap amplitude events --------- * Update IBC overrides to use POL (#3839) --------- Co-authored-by: Jon Ator <[email protected]> Co-authored-by: yakuramori <[email protected]> Co-authored-by: Connor Barr <[email protected]> Co-authored-by: Max Millington <[email protected]> --------- Co-authored-by: Matt Upham <[email protected]> Co-authored-by: Connor Barr <[email protected]> Co-authored-by: ghost <[email protected]> Co-authored-by: yakuramori <[email protected]> Co-authored-by: Jon Ator <[email protected]>
What is the purpose of the change:
Linear Task
https://linear.app/osmosis/issue/FE-1077/v26-fe-tasks
Brief Changelog
Testing and Verifying
screenshot of removed Ledger copy
