check for nil response data in numia tokens endpoint

[jonator]

What is the purpose of the change:

Linear Task

It seems recently, Numia has started to return null (vs 0) for volume24h and liquidity for some tokens in the /tokens/v2/all endpoint. This PR handles that gracefully.

Removes old token query store to remove footgun.

Brief Changelog

• Handles null liquidity value by defaulting to 0 before passing to PricePretty
• Adds extra check for null when indexing into SQS price map for redundancy

Testing and Verifying

[coderabbitai]

Warning

Rate limit exceeded

@jonator has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 4 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4d18ec2 and da3d10a.

Walkthrough

The changes in this pull request involve enhancements to error handling and data structure flexibility within the codebase. The makeMarketActivityFromTokenData function now uses the nullish coalescing operator to ensure that certain fields default to 0 when null or undefined. The getBatchLoader function has improved error handling to manage cases where price data is unavailable. Additionally, the TokenData interface has been updated to allow the liquidity property to accept null values, accommodating scenarios where liquidity data may not be present.

Changes

File Path	Change Summary
.../queries/complex/assets/market.ts	Updated liquidity initialization in makeMarketActivityFromTokenData to use nullish coalescing.
.../queries/complex/assets/price/providers/sidecar.ts	Enhanced error handling in getBatchLoader by adding a check for nil price values.
.../queries/data-services/token-data.ts	Modified TokenData interface to allow liquidity property to be of type `number

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 18, 2024 8:36pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Sep 18, 2024 8:36pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Sep 18, 2024 8:36pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Sep 18, 2024 8:36pm
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Sep 18, 2024 8:36pm

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8956a00 and f94aa6d.

Files selected for processing (3)

• packages/server/src/queries/complex/assets/market.ts (1 hunks)
• packages/server/src/queries/complex/assets/price/providers/sidecar.ts (4 hunks)
• packages/server/src/queries/data-services/token-data.ts (1 hunks)

Additional comments not posted (3)

packages/server/src/queries/complex/assets/price/providers/sidecar.ts (2)

3-3: LGTM!

The addition of the isNil import from @osmosis-labs/utils is a valid change. It will likely be used to handle null or undefined values in the modified code.

---

Line range hint 34-49: Improved error handling for nil price values.

The added check using isNil to determine if the price variable p is null or undefined enhances the error handling in the getBatchLoader function. Throwing an error when p is nil prevents potential downstream issues when processing prices and provides a clear indication of the specific baseCoinMinimalDenom and USDC pair for which the price result is missing.

This change improves the robustness and maintainability of the price querying process.

packages/server/src/queries/complex/assets/market.ts (1)

234-234: Improved handling of null or undefined liquidity values.

The change to use the nullish coalescing operator (??) is a good improvement. It ensures that if tokenData.liquidity is null or undefined, it defaults to 0. This prevents potential errors related to undefined values and guarantees that liquidity is always a valid number.