-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Skip API key with tx status endpoints #3849
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { BridgeEnvironment, SkipApiClient } from "@osmosis-labs/bridge"; | ||
import { NextApiRequest, NextApiResponse } from "next"; | ||
|
||
/** This edge function is necessary to invoke the SkipApiClient on the server | ||
* as a secret API key is required for the client. | ||
*/ | ||
export default async function skipTrackTx( | ||
req: NextApiRequest, | ||
res: NextApiResponse | ||
) { | ||
const { chainID, txHash, env } = req.query as { | ||
chainID: string; | ||
txHash: string; | ||
env: BridgeEnvironment; | ||
}; | ||
|
||
if (!chainID || !txHash || !env) { | ||
return res.status(400).json({ error: "Missing required query parameters" }); | ||
} | ||
|
||
const skipClient = new SkipApiClient(env); | ||
|
||
try { | ||
const status = await skipClient.trackTransaction({ chainID, txHash }); | ||
return res.status(200).json(status); | ||
} catch (error) { | ||
if (error instanceof Error) { | ||
return res.status(500).json({ error: error.message }); | ||
} | ||
return res.status(500).json({ error: "An unknown error occurred" }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { BridgeEnvironment, SkipApiClient } from "@osmosis-labs/bridge"; | ||
import { NextApiRequest, NextApiResponse } from "next"; | ||
|
||
/** This edge function is necessary to invoke the SkipApiClient on the server | ||
* as a secret API key is required for the client. | ||
*/ | ||
export default async function skipTxStatus( | ||
req: NextApiRequest, | ||
res: NextApiResponse | ||
) { | ||
const { chainID, txHash, env } = req.query as { | ||
chainID: string; | ||
txHash: string; | ||
env: BridgeEnvironment; | ||
}; | ||
|
||
if (!chainID || !txHash || !env) { | ||
return res.status(400).json({ error: "Missing required query parameters" }); | ||
} | ||
|
||
const skipClient = new SkipApiClient(env); | ||
|
||
try { | ||
const status = await skipClient.transactionStatus({ chainID, txHash }); | ||
return res.status(200).json(status); | ||
} catch (error) { | ||
if (error instanceof Error) { | ||
return res.status(500).json({ error: error.message }); | ||
} | ||
return res.status(500).json({ error: "An unknown error occurred" }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this call short-circuit the
poll
if it fails since this is returning a promise without a catch statement?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYM without a catch statement? I believe what would happen here is it would be transformed into the same promise that is awaited at the initial call above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wouldn’t, since this isn't a recursive call and it's using the dependency-injected method. If we want to share the catch statement, we’d likely need to create an inline function and call it inside the catch method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow, how would this look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we could avoid recursion by just adding a catch. It will just call the method on the next poll cycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think recursion is being used, we're just calling the same given function twice