Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python3 by updating to package.xml format 3 #91

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 10, 2020

Using conditional dependencies in format 3, depend on the python3 version of things in focal/noetic.

@sloretz will you review this since you've seen several related cases?

@wjwwood wjwwood requested a review from sloretz March 10, 2020 22:57
@wjwwood wjwwood self-assigned this Mar 10, 2020
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, the rest LGTM

@wjwwood
Copy link
Member Author

wjwwood commented Mar 10, 2020

Same test that is getting a timeout, ignoring for now.

@wjwwood wjwwood merged commit 2b48936 into master Mar 10, 2020
@wjwwood wjwwood deleted the support_python3_deps branch March 10, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants