Reorganize buoy_msgs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
This was referenced Aug 19, 2022
quarkytale
approved these changes
Aug 22, 2022
| # find dependencies | ||
| find_package(ament_cmake REQUIRED) | ||
| find_package(rclcpp REQUIRED) | ||
| find_package(buoy_interfaces REQUIRED) |
|
|
||
| <exec_depend>buoy_interfaces</exec_depend> | ||
| <exec_depend>buoy_api_cpp</exec_depend> | ||
| <exec_depend>buoy_api_py</exec_depend> |
|
|
||
| <buildtool_depend>rosidl_default_generators</buildtool_depend> | ||
| <exec_depend>rosidl_default_runtime</exec_depend> | ||
|
|
||
| <depend>geometry_msgs</depend> | ||
| <depend>std_msgs</depend> |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from ament_flake8.main import main_with_errors |
There was a problem hiding this comment.
Getting warnings here fir test_flake8.py and test_pep257.py
Warning: The (fspath: py.path.local) argument to Package is deprecated. Please use the (path: pathlib.Path) argument instead.
Warning: The (fspath: py.path.local) argument to Module is deprecated. Please use the (path: pathlib.Path) argument instead.
Warning: distutils Version classes are deprecated. Use packaging.version instead.
But I guess we can ignore them for now?
| @@ -0,0 +1,4 @@ | |||
| [develop] | |||
There was a problem hiding this comment.
What's the empty resource file buoy_api_py/resource/buoy_api_py used for ?
| <buildtool_depend>ament_cmake</buildtool_depend> | ||
|
|
||
| <depend>rclcpp</depend> | ||
| <depend>buoy_interfaces</depend> |
| @@ -0,0 +1,14 @@ | |||
| # buoy_api_cpp | |||
|
|
|||
| `buoy_api_cpp` provides API for MBARI Power Buoy. | |||
| std::vector<float> N_Spec; // RPM | ||
| std::vector<float> Torque_Spec; // N-m | ||
| std::vector<float> I_Spec; // Amps | ||
| JustInterp::LinearInterpolator<float> interp1d; |
There was a problem hiding this comment.
Saw this at a couple of places, is this variable name intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #21 to support #20