fix(askalono): Crawl in all files instead of just license-like ones #10380
Conversation
sschuberth
force-pushed
the
askalono-all-files
branch
from
4db6287 to
056ae76
Compare
Also see the hint at [2]. [1]: https://github.com/BurntSushi/ripgrep/blob/6dfaec03e830892e787686917509c17860456db1/crates/ignore/src/default_types.rs#L123-L149 [2]: jpeddicord/askalono#56 (comment) Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
askalono-all-files
branch
from
056ae76 to
5bf0c11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10380 +/- ##
============================================
+ Coverage 56.62% 56.66% +0.03%
+ Complexity 1630 1625 -5
============================================
Files 332 332
Lines 12324 12343 +19
Branches 1139 1148 +9
============================================
+ Hits 6979 6994 +15
- Misses 4914 4917 +3
- Partials 431 432 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sschuberth
changed the title
| @@ -131,7 +131,7 @@ class Askalono( | |||
| override fun runScanner(path: File, context: ScanContext): String { | |||
| val process = AskalonoCommand.run( | |||
| "--format", "json", | |||
| "crawl", path.absolutePath | |||
| "crawl", "--glob", "*", path.absolutePath | |||
There was a problem hiding this comment.
Maybe this should be changed to take the arguments from the configuration property, then it would work correctly with the scan result storage (just adding the option here will not trigger a rescan).
There was a problem hiding this comment.
But wouldn't it be confusing to have a glob option for this scanner, but not for others?
There was a problem hiding this comment.
Ah, you mean the whole command line, like for ScanCode, I guess.
There was a problem hiding this comment.
Yes, that's what I meant. Not making it configurable, but just making it visible to the matcher for the scan storage.
Pull request was converted to draft
Also see the hint at 1.