Skip to content

Commit

Permalink
Improve stability of tests when compiling with --with-llvm
Browse files Browse the repository at this point in the history
Some tests have been generating diffs when linking pg_hint_plan to LLVM,
and generated extra information in the plans without changing their
stability.  Let's disable JIT in the tests where this happened, for now,
improving the stability of the tests.

Per issue #199.

Reported-by: Shinya Kato
Backpatch-through: 17
  • Loading branch information
michaelpq committed Aug 26, 2024
1 parent 44f73c6 commit 85e07af
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions expected/ut-J.out
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET search_path TO public;
SET max_parallel_workers_per_gather TO 0;
SET jit = off;
EXPLAIN (COSTS false) SELECT * FROM s1.t1, s1.t2 WHERE t1.c1 = t2.c1;
QUERY PLAN
------------------------------------
Expand Down
1 change: 1 addition & 0 deletions expected/ut-R.out
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ LOAD 'pg_hint_plan';
SET pg_hint_plan.enable_hint TO on;
SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET jit = off;
SET search_path TO public;
SELECT explain_filter('
EXPLAIN SELECT * FROM s1.t1, s1.t2 WHERE t1.c1 = t2.c1;
Expand Down
1 change: 1 addition & 0 deletions expected/ut-S.out
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET search_path TO public;
SET max_parallel_workers_per_gather TO 0;
SET jit = off;
EXPLAIN (COSTS false) SELECT * FROM s1.t1 WHERE t1.c1 >= 1;
QUERY PLAN
---------------------
Expand Down
1 change: 1 addition & 0 deletions sql/ut-J.sql
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET search_path TO public;
SET max_parallel_workers_per_gather TO 0;
SET jit = off;

EXPLAIN (COSTS false) SELECT * FROM s1.t1, s1.t2 WHERE t1.c1 = t2.c1;

Expand Down
1 change: 1 addition & 0 deletions sql/ut-R.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ LOAD 'pg_hint_plan';
SET pg_hint_plan.enable_hint TO on;
SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET jit = off;
SET search_path TO public;
SELECT explain_filter('
EXPLAIN SELECT * FROM s1.t1, s1.t2 WHERE t1.c1 = t2.c1;
Expand Down
1 change: 1 addition & 0 deletions sql/ut-S.sql
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ SET pg_hint_plan.debug_print TO on;
SET client_min_messages TO LOG;
SET search_path TO public;
SET max_parallel_workers_per_gather TO 0;
SET jit = off;

EXPLAIN (COSTS false) SELECT * FROM s1.t1 WHERE t1.c1 >= 1;
EXPLAIN (COSTS false) SELECT * FROM s1.t1 WHERE t1.c1 = 1;
Expand Down

0 comments on commit 85e07af

Please sign in to comment.