Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: global refacto #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: global refacto #1

wants to merge 1 commit into from

Conversation

Sanix-Darker
Copy link
Member

WHAT

  • update dependencies
  • update the code from the bump
  • fix some stuff and clean others things

@Sanix-Darker
feat: global refacto
3944c97 
- update dependencies
- update the code from the bump
- fix some stuff and clean others things
elhmn
elhmn reviewed Aug 6, 2022
View reviewed changes
Copy link
Member

@elhmn elhmn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not very clear to me what are the changes you did to solve issues that may have come with dependencies upgrades, and other additional changes.

We want to make sure we don't change the original code behaviour, this why I will suggest splitting this work in a pull request only about the dependencies version bumps and other fixes and linting you may have done.

client/src/game/game.js
var client = new Colyseus.Client(endpoint);

console.log('client => ', client)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@Sanix-Darker
Copy link
Member Author

We want to make sure we don't change the original code behaviour

I didn't changed that 🤔 , just updated the code accordingly to the bump !
It;s on the PR description and the commit message !
All changes are related to the evolution of the api of dependencies !

this why I will suggest splitting this work in a pull request only about the dependencies version bumps and other fixes and linting you may have done

If you bump dependencies without changing the code (libs API's functions), the project will not even started 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elhmn elhmn elhmn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sanix-Darker @elhmn