Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

feat: add Mycoolplay #6

Closed
wants to merge 1 commit into from
Closed

Conversation

Theryx
Copy link
Contributor

@Theryx Theryx commented Jul 12, 2021

This pull request adds Mycoolplay to the catalogue
the app infos was copied from https://my-coolpay.com/en/

related to #1

Copy link
Member

@elhmn elhmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this issue 🙇‍♂️ , I just left few comments regarding the file format that was changed and a dikalo field that we could remove. 👍

@@ -32,22 +32,22 @@ items:
- https://blog.osscameroon.com
- https://miniyotas.osscameroon.com
image: default.svg
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your text editor, has reformatted the file, is it possible to change this line back, as they were before ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for pointing that. I did not notice. please help me interpret what changed?
what does the blue and red represent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, The green line refers to what you have added in your PR, the stronger green on line 35 highlight a space between the beginning of the line and the comment. You should remove this space, I guess

- title: Python Cameroun
category: community
#max of five tags
tags:
- programming
- developers
description: |
The cameroon based python community organization.
The cameroon based python community organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

website: https://pythoncm.org
#twitter group handle
twitter: https://twitter.com/PythonCameroun
github_account: https://github.com/python-cameroun
telegram: https://t.me/python_cameroon
image: python_cameroun.jpeg
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -65,7 +65,7 @@ items:
telegram: https://t.me/joinchat/FzwEmhVrJcOnxQdG6ETtCA
slack: https://laravel.cm/join-slack
image: laravel_cm.jpeg
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -79,7 +79,7 @@ items:
playstore: https://play.google.com/store/apps/details?id=co.dklo.mbuntu
appstore: https://about.dklo.co/mbuntu-beta-ios-en
image: mbuntu.jpeg
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -156,7 +156,7 @@ items:
#github_account full url
github_account: https://github.com/blurdylan/lamap-bot
image: lamap_bot.png
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -169,7 +169,7 @@ items:
#twitter group handle
twitter: https://twitter.com/Qui_Go
image: quigo.png
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -182,15 +182,33 @@ items:
twitter: https://twitter.com/MyStoreAfrica
telegram: https://t.me/mystoreafrica_bot
image: https://mystore.africa/assets/img/logo-two.png
#--------------------------------------------------------------
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

website: https://www.hostme.space
telegram: https://t.me/hostme_space
image: https://hostme.space/front_asset/img/logo/logo.png
#--------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should not be indented

Comment on lines +209 to +210
#dikalo group handle or link
dikalo:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there is no dikalo link maybe it is worth removing it ?

@elhmn elhmn mentioned this pull request Jul 13, 2021
@elhmn
Copy link
Member

elhmn commented Jul 23, 2021

I am closing this PR as a fix PR was created here #10

@elhmn elhmn closed this Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants