feat: implementation of post and put method on alerts #136
Conversation
yokwejuste
changed the title
Hey @Sanix-Darker can you have a look at this once more? |
| @@ -18,8 +18,6 @@ | |||
| app.config.from_object(DevConfig) | |||
|
|
|||
| cors = CORS(app) | |||
There was a problem hiding this comment.
I was just asking to add comments here telling the reason you added those, not remove them 😅
There was a problem hiding this comment.
For now, i do prefer it like that too,
We're still in development so, warnings are not that way hurting. :)
| db.session.query(Alert).filter(Alert.id == alert_id).update(request.json) | ||
| db.session.commit() |
There was a problem hiding this comment.
Much better !
Did you tested it to be sure everything was working fine ?
There was a problem hiding this comment.
Yeah, i did the testing.
In fact I tested the post and it works well, but as for the put, i don't know how to target the id of the alert, cause the alert is parse as a get argument /alerts?id=45
How can i get the id and send it to my put method
....
def put(self, alert_id):
.....
......Help please 🙏
There was a problem hiding this comment.
you can get access to it by using the request's arguments
There was a problem hiding this comment.
how can I do this sir? please a reference or a hint to illustrate this?
| **request.json, | ||
| **{ | ||
| "date": datetime.datetime.now().date(), | ||
| "begin_time": datetime.datetime.now().time(), |
There was a problem hiding this comment.
@yokwejuste good job, i have some questions
1 - why is not the begin and end time not comming from the user's inputs
There was a problem hiding this comment.
2 - is it not better to check the user input and not directlly trust it(at least for the foreignkey)??
There was a problem hiding this comment.
@yokwejuste good job, i have some questions
1 - why is not the begin and end time not comming from the user's inputs
Normally an alert starts when the user tell's us about.
Should we get the start time from the user?
There was a problem hiding this comment.
2 - is it not better to check the user input and not directlly trust it(at least for the foreignkey)??
Here, I'm not getting you,
Can you please be more explicit?
There was a problem hiding this comment.
About the start time i'n nor sur we can first live it like it is
for the question 2.
a user send for example send 0 for a string as city_id(in bot case they are invalid because the ciry_id should be the id of and existing city) so we have to manually check en validate inputs before saving it in the database
| db.session.query(Alert).filter(Alert.id == alert_id).update(request.json) | ||
| db.session.commit() |
There was a problem hiding this comment.
you can get access to it by using the request's arguments
yokwejuste
requested review from
Zaker237 and
Sanix-Darker
and removed request for
Zaker237 and
Sanix-Darker
No description provided.