This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
feat: add Twitter post notification on new blog article #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, but this PR concerns issue #50 |
Comment on lines
+104
to
+128
| find ./content/post -name '*.md' | sort | uniq > current_branch_files | ||
| CURRENT_BRANCH_FILES=$(cat current_branch_files) | ||
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
| git config --global user.name "github-actions[bot]" | ||
| git stash && git checkout HEAD~ && git clean -fdx && \ | ||
| find ./content/post -name '*.md' | sort | uniq > previous_branch_files | ||
| PREVIOUS_BRANCH_FILES=$(cat previous_branch_files) | ||
| echo "current_branch_files=$CURRENT_BRANCH_FILES" | ||
| echo "=========================================" | ||
| echo "previous_branch_files=$PREVIOUS_BRANCH_FILES" | ||
| echo "++++++++++++++++++++++++++++++++++++++++++++" | ||
| echo "$CURRENT_BRANCH_FILES" > current_branch_files | ||
|
|
||
| set +e | ||
| POTENTIAL_ARTICLES=$(diff current_branch_files previous_branch_files | grep "content" | sed 's/[<>] //g') | ||
| set -e | ||
|
|
||
| #Fail if there was no potential articles found | ||
| test ! -z "$POTENTIAL_ARTICLES" | ||
| echo "message<<EOF" >> $GITHUB_ENV | ||
| echo "Checkout this article on our blog." >> $GITHUB_ENV | ||
| for article in $POTENTIAL_ARTICLES; do | ||
| echo "> https://blog.osscameroon.com$(echo $article | sed "s/\.md//g; s/^\.\/content//g")" >> $GITHUB_ENV | ||
| done | ||
| echo "EOF" >> $GITHUB_ENV |
There was a problem hiding this comment.
Optional suggestion:
I will suggest to add this inside a bash script following the example made on 'notify_on_pull_request', so that this file will doesn't get too fat ('blog-deploy/blog-deploy.sh')...
What do you think ?
Co-authored-by: darker <[email protected]>
|
@elhmn note to myself 👉 review this at some point |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly too sure about this commit, but could the maintainers test it please ?