Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Jupyterlab 4 #95

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

linuxrider
Copy link

This PR adds support for jupyterlab 4+

Copy link

Binder 👈 Launch a Binder on branch linuxrider/jupyterlab-mol-visualizer/jl4

@dou-du
Copy link
Contributor

dou-du commented May 23, 2024

@linuxrider Thanks a lot! This is really great! Sorry for not checking ealier. However, I was not able to install this PR successfully with the latest JupyterLab. I have adopted your updates and using the latest template. I will merge them into the new released code.

@dou-du
Copy link
Contributor

dou-du commented May 24, 2024

@linuxrider By the way, could you tell me your name and affiliation? We are going to finish a research paper about Jupyter widgets and extensions. We would like to acknowledge you in the paper. Thanks!

@linuxrider
Copy link
Author

@linuxrider Thanks a lot! This is really great! Sorry for not checking ealier. However, I was not able to install this PR successfully with the latest JupyterLab. I have adopted your updates and using the latest template. I will merge them into the new released code.

I thought I checked that the binder was working.
I have pushed the rest of my local changes and checked the binder. Is seems to work. It displayed a cube file.

@linuxrider
Copy link
Author

@linuxrider By the way, could you tell me your name and affiliation? We are going to finish a research paper about Jupyter widgets and extensions. We would like to acknowledge you in the paper. Thanks!

Johannes M. Hermann, Ulm University, Institute of Electrochemistry
https://orcid.org/0000-0001-7119-1295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants