-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning numpy, pytest, widget_code_input versions and drop notebook 7 tests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
fix/black-24-upgrade
branch
from
June 27, 2024 22:01
ebb31d0
to
4258d45
Compare
pytest-selenium==4.0.1 is not compatible with pytest>=8.0.0. pytest-selenium==4.1.0 should be compatible according to release info, but is not downloaded. Need to check why. Now the test actually fail because of a logical error that I need to debug locally |
agoscinski
force-pushed
the
fix/black-24-upgrade
branch
3 times, most recently
from
July 1, 2024 04:32
91a34ab
to
677d002
Compare
agoscinski
changed the title
Upgrade black to 24.* and introduce new formatting
Pinning numpy, pytest, widget_code_input versions
Jul 1, 2024
numpy 2.0.0 API causes the assert tests to fail. To temporary fix this we pin numpy to < 2.0.0. We will solve this in a dedicated PR. See issue #48
agoscinski
force-pushed
the
fix/black-24-upgrade
branch
from
July 1, 2024 04:39
677d002
to
c8fa59a
Compare
agoscinski
force-pushed
the
fix/black-24-upgrade
branch
2 times, most recently
from
July 1, 2024 20:36
7dbbe3f
to
2c03ef7
Compare
agoscinski
force-pushed
the
fix/black-24-upgrade
branch
from
July 1, 2024 20:41
34f8527
to
72d4d47
Compare
agoscinski
changed the title
Pinning numpy, pytest, widget_code_input versions
Pinning numpy, pytest, widget_code_input versions and drop notebook 7 tests
Jul 1, 2024
agoscinski
added a commit
that referenced
this pull request
Jul 2, 2024
… tests (PR #46) Since the last PR has been 6 months ago the rolling versions caused the tests to fail, we upper bound the versions of several packages to fix these issues. For some yet unknown reasons notebook 7 shows behaviors that are unfeasible to fix, therefore the tests are dropped till these issues have been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last PR has been 6 months ago the rolling versions caused the tests to fail, we upper bound the versions of several packages to fix these issues.
📚 Documentation preview 📚: https://scicode-widgets--46.org.readthedocs.build/en/46/