Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning numpy, pytest, widget_code_input versions and drop notebook 7 tests #46

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Jun 27, 2024

Since the last PR has been 6 months ago the rolling versions caused the tests to fail, we upper bound the versions of several packages to fix these issues.


📚 Documentation preview 📚: https://scicode-widgets--46.org.readthedocs.build/en/46/

@agoscinski
Copy link
Collaborator Author

pytest-selenium==4.0.1 is not compatible with pytest>=8.0.0. pytest-selenium==4.1.0 should be compatible according to release info, but is not downloaded. Need to check why. Now the test actually fail because of a logical error that I need to debug locally

@agoscinski agoscinski force-pushed the fix/black-24-upgrade branch 3 times, most recently from 91a34ab to 677d002 Compare July 1, 2024 04:32
@agoscinski agoscinski changed the title Upgrade black to 24.* and introduce new formatting Pinning numpy, pytest, widget_code_input versions Jul 1, 2024
numpy 2.0.0 API causes the assert tests to fail. To temporary fix this
we pin numpy to < 2.0.0. We will solve this in a dedicated PR. See issue
#48
@agoscinski agoscinski marked this pull request as ready for review July 1, 2024 04:39
@agoscinski
Copy link
Collaborator Author

agoscinski commented Jul 1, 2024

tests-notebook-7 fail because of #49 and #50, will continue without the tests, because it is unfeasible to fix these issues for now.

A temporary fix for the failure of the selenium tests.
See issue #47
The new widget_code_input introudces completely style of the
WidgetCodeInput that introduces the widgets tests to fail. We will
upgrade to widget_code_input 4 in a dedicated PR. See PR #45.
@agoscinski agoscinski force-pushed the fix/black-24-upgrade branch 2 times, most recently from 7dbbe3f to 2c03ef7 Compare July 1, 2024 20:36
The new version updates have made the notebook 7 tests
unfeasible to further maintain. See issues #49 and #50.
@agoscinski agoscinski changed the title Pinning numpy, pytest, widget_code_input versions Pinning numpy, pytest, widget_code_input versions and drop notebook 7 tests Jul 1, 2024
@agoscinski agoscinski merged commit 3f40362 into main Jul 1, 2024
2 checks passed
@agoscinski agoscinski deleted the fix/black-24-upgrade branch July 1, 2024 20:46
agoscinski added a commit that referenced this pull request Jul 2, 2024
… tests (PR #46)

Since the last PR has been 6 months ago the rolling versions caused the
tests to fail, we upper bound the versions of several packages to fix
these issues. For some yet unknown reasons notebook 7 shows behaviors
that are unfeasible to fix, therefore the tests are dropped till these
issues have been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant