Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend-go] Add unit test for object type detect and fix logic #1972

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

arthurscchan
Copy link
Contributor

@arthurscchan arthurscchan commented Jan 14, 2025

This PR fixes the logic to allow detection of type for short variable declaration. This is necessary to allow tracing the correct function callsites. A unit testing contains 3 methods with the same name declared in different structs helps to test the correctness of type detection.

Additional detection of other object declaration approach will be added in later PR.

@arthurscchan arthurscchan marked this pull request as ready for review January 14, 2025 19:24
@arthurscchan arthurscchan marked this pull request as draft January 14, 2025 19:40
@arthurscchan arthurscchan marked this pull request as ready for review January 14, 2025 19:40
@DavidKorczynski DavidKorczynski merged commit 4577575 into ossf:main Jan 14, 2025
11 checks passed
@arthurscchan arthurscchan deleted the fix-go-variable-detect branch January 16, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants