Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analysis: Change analysis interface to allow passing in properties #1993

Merged
merged 16 commits into from
Jan 20, 2025
Merged

analysis: Change analysis interface to allow passing in properties #1993

merged 16 commits into from
Jan 20, 2025

Conversation

arthurscchan
Copy link
Contributor

This PR changes the analysis API to allow passing in additional properties from CLI for processing. This PR also initialise a new analysis for source file line function searching. The actual works for the analysis will be done in later PR.

@arthurscchan arthurscchan marked this pull request as ready for review January 17, 2025 22:01
DavidKorczynski
DavidKorczynski requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "properties" is too broad. We should add these options on a case-by-case basis, e.g. just have a lot of --enable-xx if needed.

@arthurscchan arthurscchan marked this pull request as draft January 20, 2025 11:29
arthurscchan and others added 5 commits January 20, 2025 11:29
@arthurscchan
Merge branch 'ossf:main' into fix-api-for-analysis
34ae096
@arthurscchan
Fix logic
8587f60 
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan
Fix formatting
283e8ca 
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan
Fix formatting
9cc9242 
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan
Fix formatting
6cea3db 
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan arthurscchan marked this pull request as ready for review January 20, 2025 14:34
@arthurscchan arthurscchan marked this pull request as draft January 20, 2025 15:29
@arthurscchan arthurscchan marked this pull request as ready for review January 20, 2025 20:19
@arthurscchan
Fix formatting
8ed7fe7 
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan
Fix formatting
32ce845 
Signed-off-by: Arthur Chan <[email protected]>
@DavidKorczynski DavidKorczynski merged commit 3b75c81 into ossf:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurscchan @DavidKorczynski