mypy: Fix mypy CI #2044
Merged
mypy: Fix mypy CI #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -21,6 +21,9 @@ | |||
| - name: Install Dependencies | |||
| run: | | |||
| pip install mypy types-PyYAML | |||
| - name: Install FI as modules | |||
| run: | | |||
| cd src && pip install . | |||
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
DavidKorczynski
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing FI to module based operation, the mypy CI fails to check on the module because the module is not installed. This PR fixes the mypy CI to install the FI modules before the checking to ensure the mypy CI picks up typing errors in the FI modules, including the tree-sitter frontend. This PR also fixes the mypy errors in frontend_cpp to pass the mypy check.