Pest 2.0 #38
Merged
Pest 2.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osteel
commented
May 1, 2023
| @@ -30,13 +30,13 @@ | |||
| "ramsey/uuid": "^4.7.3" | |||
| }, | |||
| "require-dev": { | |||
| "eventsauce/test-utilities": "^3.2", | |||
| "eventsauce/test-utilities": "dev-main", | |||
osteel
commented
May 1, 2023
There was a problem hiding this comment.
ℹ️ Removed the DotEnv stuff for now as I actually don't need it
osteel
commented
May 1, 2023
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| $acquisitions = SharePoolingAssetAcquisitions::make(...$items); | |||
|
|
|||
| expect($acquisitions->quantity())->toBeInstanceOf(Quantity::class)->toMatchObject(new Quantity($total)); | |||
| expect($acquisitions->quantity())->toBeInstanceOf(Quantity::class)->toEqual(new Quantity($total)); | |||
There was a problem hiding this comment.
ℹ️ Not sure why these started to fail all of a sudden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades Pest to v2.0.
Explanation
This is so the configuration is up to date for the next instalment of the blog series.
I also want to make use of the new architecture plugin but that will be done in an eventual PR.
Checklist