Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the tracking of the fiat balance.
Explanation
Since UK tax payers are to report any capital gain or loss occurred for any transaction, including crypto-to-crypto ones, the total reported capital gain or loss doesn't necessarily reflect the actual value gained or lost in fiat terms.
This PR monitors all the swap transactions where either the acquired or disposed of asset is a fiat amount, for share pooling transactions as well as NFT ones.
Since this value is for information only and isn't meant to be reported to HMRC, I didn't use Event Sourcing to keep track of its state.
There's simply a
Summary
"projection" (Eloquent model) that anUpdateSummary
action updates. The action is called by both theSharePoolingAssetReactor
andNonFungibleAssetReactor
classes. ASummaryRepository
class is used to retrieve the summary.Checklist