Feature/poll smdpplus for install and download statuses #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lus-for-install-and-download-statuses
…lus-for-install-and-download-statuses
…ting anything though.
…here the new functionality would apply, so it still needs to be amended a bit.
…tually tests the functionality of the poller.
…ities, in preparation of removing them where they are duplicated.
…tionFixture for greater conciseness
kmmatwork
reviewed
Dec 4, 2019
sim-administration/es2plus4dropwizard/src/main/kotlin/org/ostelco/sim/es2plus/Es2PlusClient.kt
Show resolved
Hide resolved
kmmatwork
reviewed
Dec 4, 2019
sim-administration/es2plus4dropwizard/src/main/kotlin/org/ostelco/sim/es2plus/Es2PlusClient.kt
Show resolved
Hide resolved
kmmatwork
reviewed
Dec 4, 2019
...n/simmanager/src/integration-test/kotlin/org/ostelco/simcards/admin/SimAdministrationTest.kt
Show resolved
Hide resolved
kmmatwork
reviewed
Dec 4, 2019
| val statuses = profileVendorAdapter.getProfileStatusList(iccidList) | ||
| statuses.mapRight{ | ||
| it.forEach { updateProfileInDb(it) } } | ||
| } // TODO: Am I missing the error situation here? |
There was a problem hiding this comment.
Should maybe log errors I think. Something like...
pvaf.getAdapterByVendorId(vendorId)
.flatMap { profileVendorAdapter ->
profileVendorAdapter.getProfileStatusList(iccidList)
.flatMap {
it.forEach ...
}
}
.mapLeft {
log errors
}
or something...
kmmatwork
reviewed
Dec 4, 2019
| val state = SmDpPlusState.valueOf(stateString.toUpperCase()) | ||
|
|
||
| if (state != SmDpPlusState.RELEASED) { | ||
| val update = simInventoryDAO.setSmDpPlusStateUsingIccid(iccid, state) |
There was a problem hiding this comment.
simInventoryDAO.setSmDpPlusStateUsingIccid(iccid, state)
.flatMap {
val report = "Updated state for iccid=$iccid to ${state.name}"
logger.info(report)
reportln(report)
it
}
.mapLeft {
reportln("Could not update iccid=$iccid still set to ${state.name}. ...")
}
Or maybe better, use fold as the function don't return anything.
kmmatwork
reviewed
Dec 4, 2019
| } | ||
|
|
||
| fun updateProfileInDb(p: ProfileStatus) { | ||
| try { |
There was a problem hiding this comment.
Should not be needed as the called functions returns an Either.
There was a problem hiding this comment.
don't understand that comment. Please elaborate.
kmmatwork
reviewed
Dec 4, 2019
...tration/simmanager/src/main/kotlin/org/ostelco/simcards/admin/PollOutstandingProfilesTask.kt
Outdated
Show resolved
Hide resolved
kmmatwork
approved these changes
Dec 4, 2019
|
Thank you Kjell. I will incorporate your suggestions and merge only after I have done so. |
…' of github.com:ostelco/ostelco-core into feature/poll-smdpplus-for-install-and-download-statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have experienced instabilities in the ES2+ callbacks. This is a patch that introduces a dropwizard task, intended to be triggered by a cronjob, that will poll the SM-DP+ via ES2+ to determine the state of the profiles that has been reserved for download, but have not yet been registered in the sim manager database as downloaded (as seen by the SM-DP+).