Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Make layering more directly re-use unencapsulation #184

Merged
merged 2 commits into from
Dec 14, 2021

Commits on Dec 13, 2021

  1. container: Make layering more directly re-use unencapsulation

    This came out of some prep work on
    ostreedev#69
    
    Right now it's confusing, the layering code ended up re-implementing
    the "fetch and unpack tarball" logic from the unencapsulation path
    unnecessarily.
    
    I think it's much clearer if the layering path just calls down
    into the unencapsulation path first.
    
    Among other things this will also ensure we're honoring the image
    verification string.
    cgwalters committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    27887c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. containers: Only open image once

    I was doing some further reading of code and noticed we opened
    the image multiple times.  I think that's not a big deal, we probably
    will reuse connections to the registry etc. internally.  But fix
    it anyways.
    cgwalters committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0570c50 View commit details
    Browse the repository at this point in the history