This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
sysroot: Add from_assume_locked
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a mess with `SysrootLock` because in practice, way, way too many APIs just take the plain old C `Sysroot` object. In this project, we added a new API that requires a `SysrootLock`, which works well when everything is using ostree-ext from the start, as it is in bootc. However in rpm-ostree we acquire the lock from C code, but want to call `remove_undeployed_images` which wants `SysrootLock`. The only practical way out of this is to add an API which asserts that the sysroot is locked and returns this wrapper. What would actually work better here is to drive this locking logic down into the C library.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a mess with
SysrootLockbecause in practice, way, way too many APIs just take the plain old CSysrootobject.In this project, we added a new API that requires a
SysrootLock, which works well when everything is using ostree-ext from the start, as it is in bootc.However in rpm-ostree we acquire the lock from C code, but want to call
remove_undeployed_imageswhich wantsSysrootLock. The only practical way out of this is to add an API which asserts that the sysroot is locked and returns this wrapper.What would actually work better here is to drive this locking logic down into the C library.