This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
commit: Skip bind mounts too #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a failure I was seeing using `buildah` in Gitlab CI; it seems like `/run/secrets` ends up as a bind mount here, and because it's a bind mount it has the same device node. With new enough Linux there's a handy attribute from the `statx` system call that will tell us whether a given path is a mount point root. Let's use that to start. (The other alternatives are much uglier; see the linked systemd git source code) We may need to end up doing some of that if we find we keep hitting this with systems that have older kernels.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failure I was seeing using
buildahin Gitlab CI; it seems like/run/secretsends up as a bind mount here, and because it's a bind mount it has the same device node.With new enough Linux there's a handy attribute from the
statxsystem call that will tell us whether a given path is a mount point root. Let's use that to start.(The other alternatives are much uglier; see the linked systemd
git source code)
We may need to end up doing some of that if we find we keep hitting this with systems that have older kernels.