This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Quiet extremely verbose tracing::debug #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're really verbose with `env RUST_LOG=debug`...most of these spans shouldn't be emitting any arguments at all . And even then let's lower to debug level for them too.
This ends up recursing into the manifest/config objects which is a wall of spam with `env RUST_LOG=debug`. Just print the merge commit to start here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree-wide: Clean up usage of
tracing::instrumentWe're really verbose with
env RUST_LOG=debug...most ofthese spans shouldn't be emitting any arguments at all . And
even then let's lower to debug level for them too.
store: Silence extremely verbose tracing::debug
This ends up recursing into the manifest/config objects
which is a wall of spam with
env RUST_LOG=debug. Just printthe merge commit to start here.