This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
proxy: Fix logic error with auth_data switch #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change switched to use `auth_data` directly instead of passing the file. Update the logic just below which needs adjustment to continue to support authenticated pulls. Signed-off-by: Colin Walters <[email protected]>
|
Will look at some test coverage for this using ghcr.io per PR |
jeckersb
approved these changes
Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change switched to use
auth_datadirectly instead of passing the file. Update the logic just below which needs adjustment to continue to support authenticated pulls.