This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
lib: fix building with musl libc #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No major changes, just defines a constant that is unavailable from the libc crate under musl.
cgwalters
approved these changes
Aug 30, 2024
| @@ -7,12 +7,18 @@ use anyhow::Result; | |||
| use cap_std::fs::Dir; | |||
| use cap_std_ext::cap_std; | |||
|
|
|||
| // Fix musl support | |||
There was a problem hiding this comment.
I'm fine with this as is but probably the best place to fix this is adding the definitions into rustix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No major changes, just defines a const that is unavailable from the libc crate under musl.
libc does not provide STATX_ATTR_MOUNT_ROOT for the musl target as the integration for it has been slow at best. Various dependent projects have included this const manually until the libc crate itself fixes the issues with musl support.
This shouldn't change compilation on glibc-based distros as conditional-compilation is invoked.