Port to ocidir 0.3, containers-image-proxy 0.7 #663
Conversation
jeckersb
force-pushed
the
ocidir-0.3
branch
from
71967c6
to
d5cd8b0
Compare
cgwalters
changed the title
|
Ah sorry, my porting to |
Holy cow is that an absolutely cryptic compiler error now 😆 |
Update containers-image-proxy to 0.7.0 Signed-off-by: John Eckersberg <[email protected]>
jeckersb
force-pushed
the
ocidir-0.3
branch
from
d5cd8b0
to
e4468f7
Compare
| } | ||
| }; | ||
|
|
||
| let driver = async { driver.await.map_err(Into::into) }; |
There was a problem hiding this comment.
seems to be enough to accomodate the thiserror change, took me longer than I would care to admit to understand the compiler error before.
There was a problem hiding this comment.
I struggled a lot with this when I was learning Rust for sure. The thing that is subtle is that the ? operator automatically also does Into::into, which means in cases where you're changing the error type (like this) but not using ? (which happens in most cases) you suddenly have to think about these conversions.
|
Ah, test run hit #664 |
|
Fallout in containers/bootc#800 I have yanked version 0.15.0. |
Signed-off-by: John Eckersberg [email protected]