Merge ostree-rs into this repository #2575

Look, the type is fine. It's only an opaque thing to ensure lifetimes anyway.

This reverts commit 20a74e0d Whoops, forgot --all-features

These might not work, I didn't test them...

I guess the failing checksumming tests were due to user IDs or file system permission problems in CI. Squashed commit of the following: commit 6680075f3fc1ce483712b1e2b7124f5b04654393 Author: Felix Krull <[email protected]> Date: Tue Sep 3 00:46:02 2019 +0200 Remove troublesome tests They seemed to be failing due to different user IDs or file system permissions. I don't know how to get them stable, so out they go. commit 6bb28dbf2ed2af093df6120d6095d1aba48fed56 Author: Felix Krull <[email protected]> Date: Tue Sep 3 00:37:15 2019 +0200 Ignore troublesome tests commit a31a347a18ef4a32cae8ec22532ce938c6000d97 Author: Felix Krull <[email protected]> Date: Tue Sep 3 00:30:17 2019 +0200 Potentially fix checksum tests commit 8e8bace9ce39d4ef709eb8806502140734eade4c Author: Felix Krull <[email protected]> Date: Mon Sep 2 23:33:31 2019 +0200 Fix actual/expected (maybe) commit ab2a1f6f13f8e607dc3824e4ccf51cebc9a17111 Author: Felix Krull <[email protected]> Date: Mon Sep 2 23:23:42 2019 +0200 Fix Checksum::from_{base64,hex} commit dd462c271ffb54190399dfe50f5797e1956f7bab Author: Felix Krull <[email protected]> Date: Mon Sep 2 23:08:29 2019 +0200 Fix Checksum::to_base64

Apparently these now change with each commit.

This reverts commit 5fb6d791

I can't get it not to check sys/build.rs.

Should be fixed in the next upstream release Ref: ostreedev#2051

I don't think the SignDummy and SignEd25519 types even need to be visible. The explicit dummy_* and ed25519_* don't need to be visible either, I suspect.

This allows us to provide actually useful error handling

Ultimately a repo is just a file descriptor wrapper with some cached data, etc. We can send it between threads, much like how `gio::File` is `Send`. Motivated by trying to write to a repo from a separate thread in https://github.com/cgwalters/ostree-container

Sync to https://github.com/ostreedev/ostree/releases/tag/v2021.2

This moves `RepoTransactionStats` into a manually implemented source file in order to provide getters to expose relevant fields.

Which is maintained and has updated rust.

An intimidating spam of compiler errors at the start, but the biggest was handling the new convention of `ostree_sys::` => `ffi::`. This will require a semver bump of course.

The glib 0.14 change is semver incompatible.

(We should add doing this as a SOP for ostree releases)

Re-export our dependencies. See https://gtk-rs.org/blog/2021/06/22/new-release.html "Dependencies are re-exported". Users will need e.g. `gio::File`, so this avoids them needing to update matching versions. Closes: ostreedev/ostree-rs#12

This fixes the definition of the `v2016_4` feature. It restores the chain of versions so that 2016.3 symbols can be actually reached from newer features/versions.

This makes sure docs can be properly built when using the 'dox' feature. It should fix auto-builds on docs.rs.

This removes stale URLs, pointing to the auto-built docpages at docs.rs and sorting manifest entries.

And add basic docs for our manually implemented functions.

This way it's more convenient for downstream crates like ostree-rs-ext to convert loaded variants. TODO: Can we add a feature for the `gvariant` crate and expose via that too?

My previous pass was at the default feature level.

It's a huge trap for us not to build with the latest ostree feature on, I didn't have my IDE configured for it, and CI didn't have it on. The previous bump to glib 0.14 broke the Sign code.

In general only `-sys` crates should depend on other `-sys` crates. IOW for us, `ostree-sys` depends on `glib-sys`. By using the re-export, we avoid needing to keep a version lock between `glib` and `glib-sys` in our main crate. And similar is true of our higher level reverse dependencies (e.g. `ostree-rs-ext`). Also weaken our dependency to `0.14` as that's clearer.

``` Colin Walters (8): Add 2021.3 feature Re-export glib, gio Deny unused results, warn on missing docs (except auto/) Add new GLib 0.14 variant types for metadata types Fix build with --features=v2021_3, use in CI by default Add more documentation for --features=v2021_3 Use glib-sys via re-exported `glib::ffi` (and similar for gio) Release 0.12.2 Luca BRUNO (5): cargo: fix version in features chain lib: fix 'dox' feature cargo: point to docs.rs and clean up ostree: release 0.12.1 cargo: bump ostree-sys to 0.8.1 ```

Matching how gtk-rs does it. Right now rpm-ostree does depend on interacting with `ostree-sys` via the cxxrs bits.

Not strictly required for this repo, but it has the new variant bindings we want in ostree-rs-ext.

No major changes, just exporting the `ffi` bits.

Just an update to support libostree v2021.4, but bumping semver because a few APIs (correctly) gained `Option<T>`.

Should have been bumped in the previous commit.

Useful with `Repo::open_at()`. Right now ostree-rs-ext pulls in libc for this and `fgetxattr`, but the latter should go into nix.

It's safe to send between threads, and I want to do so in ostree-rs-ext to send to a tokio worker thread.

The `dfd()` API returns just an integer. Add a safe API that makes a copy of the fd. What we really want here is `BorrowedFd` from https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md but that isn't here yet.

This gives auto-cancelling semantics on `Drop`, plus a nicer `.commit()` method on the transaction. Matches the currently private `_OstreeRepoAutoTransaction` in the C library.

The `resolve_rev` C method should really have been `resolve_rev_optional` from the start - it is more obviously wrong in Rust because the input parameter `allows_noent` controls whether the returned `Option` can ever be `None`. I debated adding this to the C bindings, and may still do so, but eh it's faster to write + ship in Rust, and the future of ostree is Rust anyways.

This adds a `SysrootBuilder` in order to allow consumers to load a configured `Sysroot` in an ergonomic way. It tries to prevent logic bugs coming from handling half-initialized entities.

This splits the builder completion step into separate actions for creating/loading a sysroot. It also introduces a roundtrip test over a freshly-created empty sysroot.

This updates stale dependencies and remove leftover settings.

This fixes the following warnings highlighted by clippy: * https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark * https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure * https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

This adds two jobs in order to check minimum toolchain compatibility, and for overall linting.

The fact that the uid/gid/mode are big endian bit me when I was trying to parse this "by hand" in ostree-rs-ext. Let's add a footgun-free API for this. (And yeah, we should probably do the same for the other variant types)

I'm trying to make more use of `cap-std` in our stack, and this will be a key enabling API. Actually a notable side benefit of this is that we don't need to teach the ostree C code itself to use `openat2`, we inherit cap-std's setup. All of the internal ostree code using the prior `openat()` should continue to work. I only did basic sanity checking of this; there may be bugs in other APIs.

Followup to the previous PR. I realized now with `io_lifetimes` we can offer a safe `dfd_borrow()` that *borrows* the file descriptor for the repository. (In contrast to the current `.dfd()` that returns the raw version) Building on that, add another API that re-acquires a `Dir` instance. (In the future in theory we could optimize this more by knowing whether or not the repo was constructed via cap-std, and perhaps in theory synthesize a `&Dir` reference, but I don't think we need that now)

Today we hardcode `/bin/bash` in https://github.com/coreos/coreos-assembler/blob/2088d24884771093101d95f915c921505128ef76/src/cmd-build#L405 But that breaks the concept of a bidirectional bridge between container image and ostree commit because this little bit of knowledge is encoded at the buildsystem side. This metadata key is intended to be written into an ostree commit, and then we will use it automatically in `container encapsulate`. The "source of truth" for this key will hence be able live in the same place that's generating the ostree commit. The more "proper" place for this is probably alongside the other constants in the libostree core C code. But that's tedious and slow to release. And Rust is the future. And we've been slowly adding more "core ostree" functionality here.

This cherry picks just the changes from ostreedev#2537 We don't need to wait to respin a new ostree release just for this.

I'm trying to debug a problem in ostree-rs-ext, and it's handy to be able to do `dbg!(mtree.copy_files())`.

The underlying `ostree_repo_load_file()` API has the caller pass `NULL` for output arguments it doesn't want. This isn't sanely bindable in Rust - what the generator does is always request all values, but maps them all to `Option<T>`. The main cases are where a user wants either metadata, or both metadata and content. This API gives just metadata; it's a bit more efficient as we don't need to open the file, and doesn't require the caller to `unwrap()`.

This manually adds a missing `ToGlibPtr` import, which seems to be result of some bugs in `gir` code-generation.

Prep for merge into ostree, where we want to run `cargo fmt` checks in CI.

I want to write APIs that *require* the caller to have set up an ostree transaction. It's natural to require passing a guard to do so. But then we want an accessor for the repo.

Fix up the paths for the crates now that the Rust bindings are in `rust/`. We can't today include the test suite because it depends on `ostree-rs-ext` which would make everything circular. (Building that now requires a separate `cd tests/inst && cargo build`)

It's really tempting to remove `make syntax-check`, it has very very rarely found any real problems. But anyways, just exclude all the binding code because it trips up random problems we simply don't care about like mentions of `O_NDELAY` in the `GLib-2.0.gir`.

`tests/inst` became its own workspace.

Need this now that it is it's own workspace.

It should replace our stub one.

We're not using Vagrant or Gitlab, and our container flow is different.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge ostree-rs into this repository #2575

Merge ostree-rs into this repository #2575

Commits on May 6, 2022

Commits on May 9, 2022