fetcher: Always open tmpfiles in repo (except on FUSE) #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4e61e6f and re-instates the fix for ensuring that we download temporary files into the repository location. However in order to ensure we don't re-introduce ostreedev#2900 we detect the case where we're writing to a FUSE mount and keep the prior behavior. I've verified that this works with flatpak. Note a downside of this is the change needs to be triplicated across the 3 http backends. This then again Closes: ostreedev#2571
cgwalters
force-pushed
the
tmpfile-not-on-revokefs
branch
from
45acf73
to
ba9c9de
Compare
|
Obscure/indirect fallout in coreos/coreos-assembler#3636. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4e61e6f and re-instates the fix for ensuring that we download temporary files into the repository location.
However in order to ensure we don't re-introduce
#2900
we detect the case where we're writing to a FUSE mount and keep the prior behavior.
I've verified that this works with flatpak.
Note a downside of this is the change needs to be triplicated across the 3 http backends.
This then again
Closes: #2571