Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/destructive: Turn off global sync() #2957

Merged

Conversation

cgwalters
Copy link
Member

Let's verify that things work with that off, as they should.

Previously:
cb73129 "deploy: Add a 5s max timeout on global filesystem sync()"

But we may still have problems even with that, see https://issues.redhat.com/browse/OCPBUGS-15917
where it might be that even a thread doesn't work because we're locked in the kernel.

Let's verify that things work with that off, as they should.

Previously:
ostreedev@cb73129
"deploy: Add a 5s max timeout on global filesystem sync()"

But we may still have problems even with that, see
https://issues.redhat.com/browse/OCPBUGS-15917
where it might be that even a thread doesn't work because
we're locked in the kernel.
Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericcurtin ericcurtin merged commit fd968d5 into ostreedev:main Jul 31, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants