switchroot: Be explicit about what could cause /sysroot to be ro #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/prepare-root
ericcurtin
force-pushed
the
explicit-sysroot-rw-ro-log
branch
from
106db08
to
f0b38ce
Compare
If you don't have rw in the kernel cmdline or have ro in it, often you hit this issue. This is just to be really explicit about that in the error messages so people can check. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
explicit-sysroot-rw-ro-log
branch
from
f0b38ce
to
e5498b9
Compare
|
I do wonder should we make src/switchroot/ostree-prepare-root-static.c and src/switchroot/ostree-prepare-root.c one combined src/switchroot/ostree-prepare-root.h file and just rewrite the functions that are different in separate .c files sometimes. |
|
On a second look the two files have diverged enough to make the above comment redundant. |
cgwalters
approved these changes
Dec 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't have rw in the kernel cmdline or have ro in it, often you hit this issue. This is just to be really explicit about that in the error messages so people can check.