Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Ignore sockets, fifos in /etc/<subdir> during merge #3143

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yummypeng
Copy link
Contributor

It's a followup of commit e6a560b. We should also ignore sockets and fifos in the subdir of /etc.

Copy link

openshift-ci bot commented Jan 22, 2024

Hi @yummypeng. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

It's a followup of commit e6a560b.
We should also ignore sockets and fifos in the subdir of /etc.

Signed-off-by: Yuanhong Peng <[email protected]>
@cgwalters
Copy link
Member

/ok-to-test

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. Would be nice to have a test but we can do that after, and I don't expect you to learn our test suite for things like this.

Thanks again!

@cgwalters cgwalters merged commit 15b64c2 into ostreedev:main Jan 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants