prepare-root: Unify root.transient with composefs #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ugly in the output.
First, I was totally wrong and composefs handles being passed an upperdir itself, we don't need to stack overlayfs. Next, there's really no reason to support `root.transient` *without* a backing composefs. The legacy ostree bind mount and readonly `/usr` is just that - legacy. Finally, we actually *must* do this to enable both composefs and transient root, because the prepare-root flow assumes that it just needs to `MS_MOVE` a *single* mount for the root, not a stack.
github-actions
bot
added
the
area/prepare-root
|
Arguably now it should be something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare-root: Add missing newline
This is ugly in the output.
prepare-root: Unify root.transient with composefs
First, I was totally wrong and composefs handles being passed
an upperdir itself, we don't need to stack overlayfs.
Next, there's really no reason to support
root.transientwithout a backing composefs. The legacy ostree bind mount
and readonly
/usris just that - legacy.Finally, we actually must do this to enable both composefs
and transient root, because the prepare-root flow assumes
that it just needs to
MS_MOVEa single mount for the root,not a stack.