-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/atomic-rollbacks: Add a section on rollbacks #3171
Conversation
6ddb3d9
to
a7529c5
Compare
Here is how is looks in .pdf format: |
|
||
set -ex | ||
|
||
if [ "$(ostree admin status -D)" = "not-default" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, that said...now that we've done all this I am still coming around to the idea that ostree should automatically inject something like ostree.fallback=/path/to/root
for all non-default entries, that way we can reliably detect this from the initramfs and properly set up the default target from the initramfs.
Anyways, something to just consider for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normally fallback at the bootloader level right? So if we have loaded a kernel+initrd+cmdline from a fallback boot entry the ostree=
karg would have the fallback root and ostree.fallback=
would have the next fallback if that makes sense.
Also... cmdlines are generated server-side, this wouldn't be able to account for clients that missed an upgrade.
You can skip an upgrade in ostree right, if you haven't upgraded in a while?
That's why it's kinda nice to have the /boot/loader data client-side, fallbacks seem like something that should be client-side determined. Because each client may have a different upgrade path (and different fallback versions, or the fallback could be on A on some clients and B on others).
Describing how different types of rollbacks work. Signed-off-by: Eric Curtin <[email protected]>
a7529c5
to
bc5c071
Compare
Addressed comments and re-pushed |
Describing how different types of rollbacks work.