refactor: simplify !with command argument parsing
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiceAesth
changed the title
!with command argument parsing
|
should be good to merge now |
tsunyoku
reviewed
Jul 13, 2023
It's a fair point, although I think it's fair to use in such a use-case of dynamically parsing user input like this. The logic is much simpler, the command itself is easier to use imo and it also adds missing support. |
minisbett
requested review from
skrungly,
NiceAesth and
7mochi
as code owners
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
replaced by #640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified the parsing, as well as adding some more "implicit" parameters to make stuff more consistent.
I also added support for mania (katu, geki)
In summary, you can now do stuff such as
!with 5x100 2x50
!with 99% 3m
!with 4x100 9m 388x
!with 97.59% 2m 473x +HDDT
!with 5xkatu 3xgeki
Dependent on #526