Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mails repository #487

Merged
merged 23 commits into from
Feb 12, 2024
Merged

refactor: mails repository #487

merged 23 commits into from
Feb 12, 2024

Conversation

7mochi
Copy link
Contributor

@7mochi 7mochi commented Sep 12, 2023

Describe your changes

Related Issues / Projects

Checklist

  • I've manually tested my code
  • The changes pass pre-commit checks (make lint)
  • The changes follow coding style

@7mochi 7mochi added the enhancement New feature or request label Sep 12, 2023
@7mochi 7mochi self-assigned this Sep 12, 2023
cmyui
cmyui reviewed Sep 13, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
@7mochi 7mochi requested a review from cmyui September 13, 2023 16:35
@NiceAesth NiceAesth added the code quality Something is implemented poorly label Sep 21, 2023
@7mochi 7mochi mentioned this pull request Sep 21, 2023
Open
17 tasks
@7mochi 7mochi changed the base branch from master to repositories September 21, 2023 13:11
@7mochi 7mochi marked this pull request as draft September 22, 2023 01:30
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
@7mochi 7mochi changed the base branch from repositories to master September 24, 2023 03:13
@7mochi 7mochi marked this pull request as ready for review September 24, 2023 03:34
@7mochi 7mochi requested a review from cmyui September 24, 2023 03:34
cmyui
cmyui reviewed Sep 24, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
cmyui
cmyui reviewed Sep 25, 2023
View reviewed changes
app/repositories/mails.py Outdated Show resolved Hide resolved
@NiceAesth
Copy link
Contributor

hey @cmyui i see you've already reviewed this along with the other repository prs. any updates on the state of these?

@cmyui
Copy link
Member

cmyui commented Feb 12, 2024 •
edited
Loading

hey @NiceAesth off-topic for this pr but something i've noticed -- rebasing/merging prs seems to update dependencies in the lockfile? see above 2 commits for an example. know why that's happening?

no rush -- i just revert the commit when it happens

cmyui
cmyui previously approved these changes Feb 12, 2024
View reviewed changes
@cmyui cmyui enabled auto-merge (squash) February 12, 2024 18:12
@cmyui cmyui merged commit 146e28f into master Feb 12, 2024
6 checks passed
@cmyui cmyui deleted the mails-repo branch February 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyui cmyui cmyui approved these changes

@skrungly skrungly Awaiting requested review from skrungly

@NiceAesth NiceAesth Awaiting requested review from NiceAesth NiceAesth is a code owner

@tsunyoku tsunyoku Awaiting requested review from tsunyoku tsunyoku is a code owner

Assignees

@7mochi 7mochi

Labels
code quality Something is implemented poorly enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7mochi @NiceAesth @cmyui